Repository navigation
chore(skills): upstream skill を更新し intent に沿って再適応する - #133
Conversation
|
Important Review skippedToo many files! This PR contains 185 files, which is 85 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
|
There was a problem hiding this comment.
Reviewed changes
Reviewed PR #133 (chore(skills): upstream skill を更新し intent に沿って再適応する): 11 upstream skills updated via skillctrl 3-way merge, plus lock.json and skills-lock.json refresh. 185 files changed.
- e2e SKILL.md — upstream reorganization absorbed; local "この環境の既定" section (OpenCode Go setup, telemetry opt-out, mise pin) preserved.
- ce-simplify-code — new Mode/standalone-report/reviewer-dispatch references added; intent (subagent-only, never inline) preserved in SKILL.md but contradicted in reviewer-dispatch.md.
- cloudflare — reference tree reorganized (old per-product dirs → new structure); local cf-via-mise and Access-AI sections preserved.
- learn — section renumbering and am CLI enhancements; local media-generation reference and japanese-tech-writing retained.
- langfuse, prototype, skillctrl, gh-stack, grilling, typesafe-ai — upstream content absorbed; local adaptations (mise, secret-env, delegate) retained.
Findings are inline below. Frontmatter and inline-fallback issues are must-fix; npx and path items are minor.
Note: 1 inline comment(s) dropped because they did not anchor to lines inside the PR diff:
.agents/skills/cloudflare/references/products-ai.md:11(RIGHT) — file not in PR diff
beam-free | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Incrementally re-reviewed PR #133 since the prior pullfrog review at 0254bfe: verified the new commit 64821e1 and confirmed all prior P1/P2 findings are resolved.
- e2e SKILL.md frontmatter — closing
---delimiter restored to its own line; YAML frontmatter now parses cleanly (resolves prior P1). - ce-simplify-code reviewer-dispatch.md — inline-review fallback replaced with "report the failure and stop; never substitute an inline review", matching the saved intent and SKILL.md (resolves prior P2).
- ce-simplify-code SKILL.md — dangling "inline fallback" clause dropped; no stale references remain (resolves prior P2).
- lock.json — accepted hashes for ce-simplify-code and e2e updated to match the adapted content; upstream hashes left unchanged.
- e2e SKILL.md — "この環境の既定" section repositioned; local adaptations (OpenCode Go setup, telemetry opt-out, mise pin, stateless tests) all preserved.
- Declined findings respected — unpinned
npx @e2e-dev/web install(P2) and Windows path placeholder (P3) were declined by the author with reasoned justifications; threads are resolved and not re-raised.
All six prior review threads are resolved. No new blocking issues found in the incremental delta.
beam-free | 𝕏

Blast Radius
中 — 11 個の upstream skill を、upstream の最新版に追従させる。差分は 185 files(+9224 / −19652)。cloudflare は upstream 側で reference が大きく再編されており、152 files がこの skill の変更。CI の repo checks と、最終の hash gate(accepted lock との一致)は通過している。
What
週次の skillctrl-update(手動 dispatch の run 40160400157)が作った更新を PR にする。workflow は branch の push までは成功した。PR の作成だけが、repo 設定「Allow GitHub Actions to create and approve pull requests」が off のため失敗したので、この PR は手動で作った。
Background
skillctrl は upstream の変更を、Git 履歴から復元した base を使って 3-way merge でローカル skill に取り込む(wwwyo/skillctrl#27, #29)。update agent が intent に沿って conflict を解消し、検証できた skill だけを
recordした。QA
Run repository checksは全項目 OK だった(skill symlink、chezmoi layout、pr_triage、skillctrl workflow 接続など)Verify the accepted lockは通過したgit grep '^<<<<<<< local'で確認した(0 件)Summary
learn/scripts/am.test.mjsなど)は残っているhttps://claude.ai/code/session_01EUgMLcfukUoucoQ5DWyw4u