Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
disk I/O errorfailures observed when running under SLURM on some HPC/shared filesystems, likely due to file locking/journaling interactions.Description
_acquire_readonly_engine()helpers toSequenceDatabaseandMetapackageReadNameStorethat construct a quoted absolute path and open the DB with a SQLite URI includingmode=ro,immutable=1, anduri=true.create_engine("sqlite:///...")calls for read/query access with the new helper so packaged DBs (e.g.otus.sqlite3andread_taxonomies.sqlite3) are opened read-only immutable when acquired.urllib.parse.quote+os.path.abspathto safely build file URIs.test/test_sqlite_readonly_mode.pyunit tests that assert the acquire paths construct the expected read-only immutable SQLite URIs.Testing
pixi run -e dev pytest testas required and the full suite completed with225 passed, 24 skipped.test_sqlite_readonly_mode.pytests pass as part of that run and validate the read-only immutable engine construction.Codex Task