Repository navigation
Explain argument-rejected run-tests receipts and guard worktree links (#2036) - #2048
Conversation
…#2036) - A static explainer shares the recognizer's playwright/node argument walk and names the rejected argument (for example `-g pat` -> `--grep=pat`, code-loading `--config`, appended `npm run <script> -- ...` args) instead of calling a citable launcher family "unrecognized". The allow-list and persisted suite_start reasons are unchanged; the notice is advisory only. - The citable-runner summary and post-auth diagnostic describe the `--name=value` allow-list rule. - Coder prompts name the coder checkout's registered --worktree-link paths as shared operator infrastructure not to be replaced, moved, copied over or deleted; the pr-local note also forbids moving/copying over. - The test broker refuses a request before reservation or launch when a registered link or private environment is not intact, naming it. The pre-check is fail-open and never poisons the checkout. Fixes #2036 Agent-Issue-Provenance: v1 repo=wwind123/coding-review-agent-loop issue=2036 flow=approved plan=e71f1299f12ce9e5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Issue implementationImplemented the approved #2036 plan in draft PR #2048. Root cause: the playwright allow-list accepts value options only in --name=value form, so ResultPull request reported: #2048. Tests run
Test observation receipts
Risk-based mode and transition test matrix evidence
Full matrix evidence (6 rows)
Risk-matrix coverage mapOrchestrator completeness check (existence and level only; whether each cited test really exercises its row is for the reviewer to judge).
-- Anthropic Claude: claude-opus-5-5 (medium) |
|
Agent-loop managed-CI resume provenance audit record (machine-readable). Records resume provenance for managed CI on pull request #2048 at head 30bfe51. Not an agent response; keep this comment. AGENT_MANAGED_CI_UNPROTECTED_OVERRIDE_V1 nonce=JOWrX2REVJXrwPAv4bYmuOayw0T5NQAJ repo=wwind123/coding-review-agent-loop base=main head=30bfe5145a128a487cf663721b9311813e7b49c8 protection=voluntary active_label_event_id=36796365673 resume_from=7046526652 provenance_head=30bfe5145a128a487cf663721b9311813e7b49c8 generation=xXLo1TW62KGb4HL3 Resume provenance only: the prior issue-created audit is not an authorization token. |
|
PR review scheduling audit: selected Codex; paused Claude, Antigravity; reason: strict pre-panel fallback: architecture identity changed; scheduler metadata recovery: latest scheduler metadata is missing or invalid; scheduler metadata recovery: current-head records lack scheduler metadata; scheduler metadata is missing or invalid; primary re-invoked with full context; phase: primary; head: 30bfe51; primary: Codex; active owners: (none); force-full: False (source: none); scheduler-policy calls avoided cumulatively: 2. |
|
Review verdict: Approved Reviewed the complete base-to-head diff at 30bfe51 and verified coverage for all six risk-matrix rows. No merge-blocking defects found. CI is passing and supplied current-head focused and full-suite receipts passed. Tests were not executed during this read-only review. -- OpenAI Codex: gpt-6.1-sol (medium) |
|
PR review round 1 reconciliation: settled reviewers: Codex. Finalization continues after reconciliation. Historical approvals remain exact-head-bound; scheduler-policy calls avoided cumulatively: 2. Phase: primary; force-full: False (source: none). |
|
PR review scheduling audit: selected Claude, Antigravity; paused Codex; reason: independent secondary audit after exact-head primary approval; phase: secondary-audit; head: 30bfe51; primary: Codex; active owners: (none); force-full: False (source: none); scheduler-policy calls avoided cumulatively: 2. |
|
Review verdict: Approved Independent secondary review of the full base-to-head diff at 30bfe51. (1) Receipt reason: -- Anthropic Claude: claude-opus-5-5 (medium) |
|
Review verdict: Approved Approved. The implementation addresses issue #2036 by introducing a static, side-effect-free explainer for argument-rejected test runs (e.g. Playwright short aliases, detached values, code-loading options, and appended script arguments) without altering the recognizer allow-list or persisted suite start reasons. Coder prompts clearly name registered worktree links as shared operator infrastructure not to be tampered with, while avoiding duplicate guidance under pr-local mode. The broker pre-check refuses requests with replaced worktree links fail-open before reservation or launch without poisoning the checkout. All enforceable risk matrix rows and acceptance criteria are covered by targeted tests, and doc updates maintain consistency. -- Google Antigravity: Gemini 3.8 Flash (High) |
|
PR review round 2 reconciliation: settled reviewers: Antigravity, Claude. Finalization continues after reconciliation. Historical approvals remain exact-head-bound; scheduler-policy calls avoided cumulatively: 2. Phase: secondary-audit; force-full: False (source: none). |
|
Managed CI authorization for exact head 30bfe51. |
Summary
Implements the approved plan for #2036.
Root cause.
_is_playwright_test_runneronly accepts long options, and accepts value options only in--name=valueform. The coder's-g '<pattern>'(a short alias with a separate value) failed that check in every variant:npx, bareplaywright, andnpm run <script> -- ... -g ..., whose appended args go through the same recognizer. The sharednode_modulessymlink had nothing to do with it. The broker persists only the coarseunrecognized-launcherreason, so the client printed "unrecognized test launcher" for a launcher family the prompt lists as citable.Changes
test_runtime.py,cli.py):explain_uncitable_launcher._is_playwright_test_runnerand_is_node_test_runnernow delegate to shared_first_rejected_*_argumentwalks. Their accepted sets are unchanged, so the explanation can never disagree with the recognizer.-g pat->--grep=pat.--config, which is never citable, including a scratch config outside the checkout--separatorNODE_OPTIONS/PW_TEST_REPORTERnpx playwrightnpm run <script> -- ...is called out as appended, with the advice to cite the unfiltered script run.CITABLE_TEST_RUNNERS_SUMMARYnow states the allow-list /--name=valuerule, and the post-authSUITE_START_UNRECOGNIZED_DIAGNOSTICno longer says the launcher is unrecognized. No persisted value changed.prompt_support.py):--worktree-linkpaths as shared operator infrastructure: do not replace, move, copy over or delete them; report dependency problems instead.config.worktree_linksalone.--worktree-setup-pr-localthe existing note stays, with its gating unchanged, and now also forbids moving and copying over. It is the only paragraph naming those links.checkout_verification.py,local_test_evidence.py):cancelledframe that names the link.docs/local_agent_loop.md,docs/architecture/execution-and-concurrency.md, and the matching entry in its decisions log. Two sentences in the architecture doc that duplicated the CLI guide were dropped to stay under the 64 KiB doc cap.Tests
tests/test_test_runtime.py:npxandnpm run -- ...forms, plus each rejection categoryNonefor unknown or unresolvable commandstests/test_agent_loop.py: the CLI notice names-g/--grep=patand never says "unrecognized test launcher", with the persisted reason and with no reason (older broker). A malformed package.json keeps the generic text.tests/test_prompts.py:tests/test_local_test_evidence.py:agent-loop run-tests -- <venv python> -m pytest tests/ -qFixes #2036
AGENT_MANAGED_CI_UNPROTECTED_OVERRIDE_V1 nonce=OoejcBVFLEA-maK_SVxy0Uf8
🤖 Generated with Claude Code
-- Anthropic Claude