Skip to content

Stabilize mesocycle E2E test by selecting real exercise items#87

Merged
wulfland merged 4 commits into
mainfrom
copilot/fix-e2e-tests-failure
Jun 1, 2026
Merged

Stabilize mesocycle E2E test by selecting real exercise items#87
wulfland merged 4 commits into
mainfrom
copilot/fix-e2e-tests-failure

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 1, 2026

The GitHub Actions E2E Tests job was failing in mesocycle.spec.ts because the test could click a non-exercise action row (Create New Exercise) and then assert for inputs that never render in that path. This updates selectors to target the intended UI elements only.

  • Root-cause alignment

    • The failing test used broad .exercise-item and global numeric-input selectors, which are ambiguous in the current modal/editor structure.
  • Selector hardening in e2e/mesocycle.spec.ts

    • Exercise selection now filters out the create-action row:
      • selects from .exercise-list .exercise-item
      • excludes entries containing Create New Exercise
    • Sets input assertion now scopes to the split-day editor’s Sets config group before resolving input[type="number"].
  • Behavioral impact

    • Keeps test intent unchanged (configure sets/reps after adding an exercise) while removing false failures caused by UI action-item collisions.
const exerciseOptions = page
  .locator('.exercise-list .exercise-item')
  .filter({ hasNotText: 'Create New Exercise' });

const setsInput = page
  .locator('.split-day-editor .config-group')
  .filter({ hasText: 'Sets' })
  .locator('input[type="number"]')
  .first();

Copilot AI changed the title [WIP] Fix failing GitHub Actions job E2E Tests Stabilize mesocycle E2E test by selecting real exercise items Jun 1, 2026
Copilot AI requested a review from wulfland June 1, 2026 09:05
@wulfland wulfland marked this pull request as ready for review June 1, 2026 09:47
@wulfland wulfland enabled auto-merge June 1, 2026 09:47
@wulfland wulfland merged commit 9606068 into main Jun 1, 2026
4 checks passed
@wulfland wulfland deleted the copilot/fix-e2e-tests-failure branch June 1, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants