feat(scheduler): let the nightly digest report every run - #123
Merged
Merged
Conversation
Validating this job yesterday meant pointing its trigger a few minutes ahead, because nothing recorded whether it had run: with no user opted in it correctly does nothing, and doing nothing left no trace. The next person asking "did it run at 03:00" would have to rig the clock again. It now logs one line per run with how many owners were opted in and how many deliverables were produced, so the 03:00 run is verifiable from the logs alone — including the ordinary case of nobody having the switch on yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validating this job yesterday meant pointing its trigger a few minutes ahead, because nothing recorded whether it had run: with no user opted in it correctly does nothing, and doing nothing left no trace. The next person asking "did it run at 03:00" would have to rig the clock again.
It now logs one line per run with how many owners were opted in and how many deliverables were produced, so the 03:00 run is verifiable from the logs alone — including the ordinary case of nobody having the switch on yet.
A test asserts the line is emitted on a run with zero opted-in owners, which is exactly the case that used to be invisible.