Repository navigation
test(hosts): cover the renewal loop and the validity deadline - #93
Merged
Merged
Conversation
wstein
force-pushed
the
test/84-renewal-loop-tests
branch
from
October 16, 2026 10:35
07ac5c7 to
509efb3
Compare
Owner
Author
|
Review CLEAR on |
wstein
force-pushed
the
pilot/installable-pilot-pr
branch
from
October 16, 2026 10:42
75526bb to
7656115
Compare
wstein
force-pushed
the
test/84-renewal-loop-tests
branch
from
October 16, 2026 10:42
509efb3 to
33804a3
Compare
Owner
Author
wstein
marked this pull request as ready for review
October 16, 2026 10:55
Owner
Author
|
Ready per owner: review CLEAR on this head; local |
wstein
force-pushed
the
pilot/installable-pilot-pr
branch
from
October 16, 2026 11:19
7656115 to
866e46c
Compare
wstein
force-pushed
the
test/84-renewal-loop-tests
branch
from
October 16, 2026 11:19
33804a3 to
0ce831f
Compare
wstein
marked this pull request as draft
October 16, 2026 11:20
wstein
marked this pull request as ready for review
October 16, 2026 11:21
Owner
Author
|
Nits fixed per owner (H66:b) in one comment-only commit. Review CLEAR on |
wstein
force-pushed
the
pilot/installable-pilot-pr
branch
from
October 16, 2026 11:31
866e46c to
2235c20
Compare
The retry clamp in session could only be exercised through a live socket. A pure sessionDeadline lets tests pin each branch directly. No behaviour change. Refs: #84 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Run's renewal branches and the clamp that bounds a session after a failed renewal had no direct tests; deleting the clamp still passed. Drive Run against a loopback TLS/WebSocket server for renewal success, renewal failure on a valid identity and reload failure, and end a blocked real ws.Read at the deadline. Rename the watchValidity test to match what it proves and register the new IDs. Refs: #84 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The reload-failure test keeps its server only for the identity fixture, and the blocked-read test proves the socket close, not a direct CloseNow call, since context cancel also closes it. Refs: #84 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
wstein
force-pushed
the
test/84-renewal-loop-tests
branch
from
October 16, 2026 11:32
0ce831f to
6189c0a
Compare
Owner
Author
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #84: tests for the renewal loop and the session validity deadline.
93ed7ad: factor the session deadline into a puresessionDeadlinefunction (no behaviour change).07ac5c7: loopback TLS/WebSocket tests for renewal success, renewal failure on a valid identity, reload failure after renewal, and a real blocked read ended at the deadline. Renames the stub-only watchdog test toTestWatchValidityCancelsOnInvalidIdentity.Each new test fails without the code it protects. The reload-failure case stubs the renewal step instead of calling the server.
Known gaps (non-blocking): the
cancel()/CloseNow()path on non-elapsed invalidity is not tested throughsession; real client-certificate mTLS is not exercised.Review: CLEAR (Opus 5.5) on 07ac5c7.
make checkon this head is pending. Stacked on the pilot PR (H51:b).🤖 Generated with Claude Code