Repository navigation
docs(contracts): add agent session interface v1 - #79
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versioned contract for the in-container agent session interface (
agent-session/1.0):contracts/agent-session-v1.md,contracts/agent-session-v1.schema.json, and thecontracts/README.mdentry (owner decisions H9:a, H16:b). Operations: hello, list, status, attach, send, stop. Operation-scoped grants (attach grant consumed atomically; control grants reusable until expiry). Errors by category name only; exit-code numbers live in ADR 0013.Evidence (exact head 46b6c57, one commit on origin/main)
make check: exit 0, 818 tests, 0 raw failures, 0 errors, manifest-qualified GREEN (clean pinned checkout,python -I -B, HEAD unmoved).Author proposals needing owner review (labelled in the file): all bounds (send 64 KiB decoded, control 16 KiB, frame 16 KiB, list 256, tail 64 KiB, deadline 30 s, resize max 500x200); control-grant reuse until expiry; a session grant does not authorize list; needs-human returned by send; attach marked mutating. Owner H38:a/H39:a pending: accept as v1 proposals, refine in
speckit-plan.Open questions (in the contract, decided in the plan): grant verification (key vs control-plane callback), transport/path in the container, idempotency key for send (removed from v1), whether the console is listed as a session.
Non-blocking nits for
speckit-planinput: category-name mapping to ADR 0013 (conflict, incompatible names); grant failure vs unauthenticated; needs-human breadth; link ADR 0013 and exit-codes.json at md:160; stale wording md:80-81; name reserved fields; closed enums vs minor-version additions.Refs #71