Repository navigation
fix(hosts): unsubscribe connection topics and keep the old socket until commit - #103
Merged
Merged
Conversation
wstein
force-pushed
the
fix/88-pubsub-close-order
branch
from
October 16, 2026 10:35
3eff33f to
ea86f0f
Compare
Owner
Author
|
Review CLEAR on |
wstein
force-pushed
the
fix/88-pubsub-close-order
branch
from
October 16, 2026 10:42
ea86f0f to
4c2daf7
Compare
Owner
Author
wstein
marked this pull request as ready for review
October 16, 2026 10:55
Owner
Author
|
Ready per owner: review CLEAR on this head; local |
wstein
force-pushed
the
fix/88-pubsub-close-order
branch
from
October 16, 2026 11:20
4c2daf7 to
ee9b025
Compare
Owner
Author
|
Restacked onto pilot |
wstein
force-pushed
the
fix/88-pubsub-close-order
branch
from
October 16, 2026 11:33
ee9b025 to
bf0aa0c
Compare
Owner
Author
…commit Each reconnect added a duplicate PubSub Registry entry, so identity_changed triggered N sweeps and grew over uptime. The old socket was also closed as replaced before the replacement slot transaction committed, so a failed replacement dropped the healthy socket and admitted none. Unsubscribe when a connection closes, and close the predecessor only after the replacement commits. Tests cover repeated reconnects and a failed replacement; both fail without the fix. Refs: #88 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
wstein
force-pushed
the
fix/88-pubsub-close-order
branch
from
October 16, 2026 12:04
bf0aa0c to
e5c5e66
Compare
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #88: connection topics and close order.
:replacedonly after the replacement transaction commits; a failed replacement keeps the existing socket open and admitted.close_resultunsubscribes the host topic, so each host keeps at most one subscription across reconnects.host_connection_unknownaudit (the slot already names the new connection). Auditing liveness transitions, including replacement, is defined in fix(hosts): audit only liveness transitions, not every heartbeat #101 (H57:a).Both new tests fail without the fix. Review: CLEAR (Opus 5.5) on 3eff33f.
make checkon this head is pending. Stacked on #100 (#87).🤖 Generated with Claude Code