[4.5.0] Add documentation on ICP secondary user stores#2303
[4.5.0] Add documentation on ICP secondary user stores#2303tharindu-nw wants to merge 2 commits into
Conversation
📝 WalkthroughSummaryThis pull request adds documentation for configuring secondary user stores in WSO2 Integration Control Plane (ICP). ChangesNew documentation file:
Navigation update:
Lines changed: +86/-0 WalkthroughThis pull request adds comprehensive documentation for configuring secondary user stores in WSO2 Integration Control Plane (ICP). The new documentation file covers login authentication using either Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
en/docs/install-and-setup/setup/user-stores/configuring-secondary-user-stores-in-icp.md (1)
18-83: ⚡ Quick winAdd an explicit “example credentials only” note before config samples.
These snippets include concrete usernames/passwords. Add a short note to replace all sample credentials with environment-specific secure values before use.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/docs/install-and-setup/setup/user-stores/configuring-secondary-user-stores-in-icp.md` around lines 18 - 83, Add a short explicit note above the config examples warning that the shown usernames/passwords are sample credentials and must be replaced with environment-specific secure values before use; place this note before the first TOML block (above the first [[secondary_user_store]] example) and ensure it references that it applies to all examples including the ReadOnlyLDAPUserStoreManager, ReadWriteLDAPUserStoreManager, and JDBCUserStoreManager/driver-specific samples so readers know to update connection_name/connection_password, username/password, url, and other secrets.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@en/docs/install-and-setup/setup/user-stores/configuring-secondary-user-stores-in-icp.md`:
- Line 15: Update the sentence that currently states users "must log in as
`domain_name/username`" to clarify that `DOMAIN/username` is the recommended
format but plain `username` is also supported as a fallback; modify the text
referencing the `domain_name` label so it says something like "Users from that
store should preferably log in as `DOMAIN/username` (e.g., `LDAP_STORE/john`),
though plain `username` is supported as a fallthrough" to align with actual
behavior.
---
Nitpick comments:
In
`@en/docs/install-and-setup/setup/user-stores/configuring-secondary-user-stores-in-icp.md`:
- Around line 18-83: Add a short explicit note above the config examples warning
that the shown usernames/passwords are sample credentials and must be replaced
with environment-specific secure values before use; place this note before the
first TOML block (above the first [[secondary_user_store]] example) and ensure
it references that it applies to all examples including the
ReadOnlyLDAPUserStoreManager, ReadWriteLDAPUserStoreManager, and
JDBCUserStoreManager/driver-specific samples so readers know to update
connection_name/connection_password, username/password, url, and other secrets.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c28ff530-919c-46f7-a386-b852fabc9b7f
📒 Files selected for processing (2)
en/docs/install-and-setup/setup/user-stores/configuring-secondary-user-stores-in-icp.mden/mkdocs.yml
Purpose
$subject
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning