Correct link resolution and add a step-by-step link fixer - #417
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| # Tag name is captured so an `<a href>` is reported as a broken LINK and an | ||
| # `<img src>` as a missing IMAGE. Lumping them together mislabels every raw-HTML | ||
| # link as an image, which sends whoever reads the report looking for the wrong thing. | ||
| HTML_SRC = re.compile(r'<(img|a|source|iframe)[^>]+(?:src|href)="([^"]+)"') |
There was a problem hiding this comment.
The regex requires double-quotes to be used, but what if single quotes are used? So it's better to watch out for both.
Purpose
Fixes three link-resolution bugs in the doc validation skill. Also adds
fix_links.pyto apply a fix plan one group at a time.Checklist
llms.txt— N/A, no doc pages in this PRGoals
Make "no broken links" mean it, and make applying link fixes reviewable.
Approach
Release note
Doc validation skill: corrected link resolution to match mkdocs, added detection of
anchors the build never generates, and added a step-by-step link fixer.
Documentation
SKILL.mdandreferences/conventions.md, in this PR.Security checks