-
Notifications
You must be signed in to change notification settings - Fork 60
Add test document with deliberate style guide violations #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Configuring Rate Limiting For Your New API | ||
|
|
||
| This guide currently explains how to configure rate limiting. The new policy engine now gives | ||
| you a powerful, seamless way to protect backends, and it's really easy! | ||
|
Comment on lines
+3
to
+4
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Remove promotional wording. Replace 🧰 Tools🪛 LanguageTool[style] ~4-~4: As an alternative to the over-used intensifier ‘really’, consider replacing this phrase. (EN_WEAK_ADJECTIVE) 🤖 Prompt for AI AgentsSources: Coding guidelines, Linters/SAST tools |
||
|
|
||
| ## What The User Should Know Before Starting | ||
|
|
||
| Let's begin. The user must have an API already published in the Developer Portal, and the | ||
| request is routed by the API Gateway to the backend after the policy engine evaluates every | ||
| incoming call against the configured quota, which means that throughput limits are applied | ||
| before authentication happens in most standard deployment topologies. | ||
|
Comment on lines
+8
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Address the reader directly and split the long sentence. Replace 🤖 Prompt for AI AgentsSources: Coding guidelines, Path instructions |
||
|
|
||
| Rate limiting is simply a way to cap traffic. It takes ~5 minutes to set up & requires no | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Replace shorthand symbols in prose. Use 🤖 Prompt for AI AgentsSource: Coding guidelines |
||
| restart. | ||
|
|
||
| #### Example 1: Configuring A Basic Policy | ||
|
|
||
| Creating a policy involves opening the Policies pane, selecting Add policy, and then | ||
| configuring the quota, the burst limit and the backend. | ||
|
Comment on lines
+18
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win Align the documented fields with the policy contract. The guide names Also applies to: 29-32, 39-40 🤖 Prompt for AI Agents📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Document the procedure as numbered steps. The sentence hides a three-step procedure. Use an ordered list, format UI elements as bold, and add the Oxford comma. Proposed procedure format-Creating a policy involves opening the Policies pane, selecting Add policy, and then
-configuring the quota, the burst limit and the backend.
+1. Open the **Policies** pane.
+2. Select **Add policy**.
+3. Configure the supported fields.🤖 Prompt for AI AgentsSources: Coding guidelines, Path instructions |
||
|
|
||
| The gateway thinks your API is healthy when it sees a 200 response. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Document the actual rate-limit response. The supplied canonical policy document states that the gateway returns HTTP 🤖 Prompt for AI AgentsSource: Coding guidelines |
||
|
|
||
| ## Advanced Configuration – Optional | ||
|
|
||
| Applying a policy is done by the administrator, it is not done by the API publisher. The | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Rewrite the passive, comma-spliced sentence. Use active voice and separate the independent clauses. For example: 🧰 Tools🪛 LanguageTool[style] ~25-~25: For a more expressive style, consider rephrasing the sentence in the active voice. (PASSIVE_VOICE_SIMPLE) 🤖 Prompt for AI AgentsSources: Coding guidelines, Linters/SAST tools |
||
| following options aren't currently supported: request-body limits, per-user quotas and | ||
| geo-based rules. | ||
|
|
||
| | Field | Description | | ||
| |---|---| | ||
| | Quota | The request count | | ||
| | Burst | The burst ceiling | | ||
|
Comment on lines
+29
to
+32
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Introduce the table and format literal field names. Add a complete sentence before the table, such as 🤖 Prompt for AI AgentsSources: Coding guidelines, Path instructions |
||
|
|
||
| For the deprecated fields, see the table above. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Fix the invalid table reference. The table does not identify any deprecated fields. Point to the correct reference, or remove this sentence. Avoid the ambiguous phrase 🤖 Prompt for AI AgentsSource: Coding guidelines |
||
|
|
||
| <img src="../assets/img/img1.png" width="700" height="420" | ||
| style="margin-left: 40px; text-align: center" /> | ||
|
Comment on lines
+36
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Make the image accessible and compliant. The image has no Proposed image markup-<img src="../assets/img/img1.png" width="700" height="420"
- style="margin-left: 40px; text-align: center" />
+<img src="../assets/img/rate-limit-policy-configuration.png"
+ alt="Rate-limit policy configuration panel with supported fields and a Save button." />🧰 Tools🪛 markdownlint-cli2 (0.23.1)[warning] 36-36: Images should have alternate text (alt text) (MD045, no-alt-text) 🤖 Prompt for AI AgentsSources: Coding guidelines, Path instructions, Linters/SAST tools |
||
|
|
||
| The panel shows the three required fields and the Save button. To learn more about quotas, | ||
| click here. This feature will eventually support MongoDB backends, and we're considering | ||
|
Comment on lines
+39
to
+40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Replace The sentence has no visible link target and violates the link-text rule. Link a meaningful phrase, and format the UI label as Save. 🤖 Prompt for AI AgentsSources: Coding guidelines, Path instructions |
||
| adding Redis support soon. | ||
|
Comment on lines
+40
to
+41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Remove unreleased backend promises. The guide says MongoDB support will arrive and Redis support is under consideration. Do not document future or unreleased capabilities. Remove this sentence or move it to a dated release note after support ships. 🤖 Prompt for AI AgentsSources: Coding guidelines, Path instructions |
||
|
|
||
| Deploy the policy on 01/02/2026 and the change goes live shortly after. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Use a timeless, unambiguous deployment instruction.
🤖 Prompt for AI AgentsSources: Coding guidelines, Path instructions |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use sentence-case headings and valid heading levels.
Use sentence case for every heading. Change the heading on Line 16 from
####to###; it skips a level after##. Replace the en dash on Line 23 with an em dash without surrounding spaces.Proposed heading fixes
Also applies to: 6-6, 16-16, 23-23
🤖 Prompt for AI Agents
Sources: Coding guidelines, Path instructions, Linters/SAST tools
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove timeless language from the guide.
The terms
new,currently, andnowmake the documentation age. Use timeless wording that describes the supported behavior directly.Also applies to: 3-4, 26-27
🤖 Prompt for AI Agents
Sources: Coding guidelines, Path instructions
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Add the required frontmatter before the title.
This file lacks
title,description,canonical_url,md_url,tags,authororauthors,last_updated, andcontent_type. Add repository-valid values before the H1.🤖 Prompt for AI Agents
Source: Path instructions