Skip to content

Fix gateway notification condition(deployement status) to exclude platform gateway#1359

Open
manodyaSenevirathne wants to merge 1 commit into
wso2:mainfrom
manodyaSenevirathne:patch-17073-public
Open

Fix gateway notification condition(deployement status) to exclude platform gateway#1359
manodyaSenevirathne wants to merge 1 commit into
wso2:mainfrom
manodyaSenevirathne:patch-17073-public

Conversation

@manodyaSenevirathne
Copy link
Copy Markdown
Contributor

Purpose

$Subject

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b7e6bb20-21ae-4e16-a56e-b078db28d2f0

📥 Commits

Reviewing files that changed from the base of the PR and between d19aa09 and c330294.

📒 Files selected for processing (1)
  • portals/publisher/src/main/webapp/source/src/app/components/Apis/Details/Environments/Environments.jsx

📝 Walkthrough

Walkthrough

The Environments component now conditionally hides the "Deployment Status" column in the internal gateways table when the API was initiated from a gateway. This visibility gate is applied to both the table header and the corresponding body cells, working alongside the existing notification enabled check.

Changes

Deployment Status Visibility

Layer / File(s) Summary
Deployment Status visibility gates
portals/publisher/src/main/webapp/source/src/app/components/Apis/Details/Environments/Environments.jsx
The "Deployment Status" column header and cell rendering in the internal gateways table now check !api.initiatedFromGateway before displaying, preventing the column from showing when the API was initiated from a gateway.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a condition to exclude platform gateway from deployment status display.
Description check ✅ Passed The description is related to the changeset, stating the purpose of updating the gateway notification condition for deployment status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants