Improve UI error handling for SSRF-blocked URL scenarios#1344
Open
JanithaSampathBandara wants to merge 4 commits into
Open
Improve UI error handling for SSRF-blocked URL scenarios#1344JanithaSampathBandara wants to merge 4 commits into
JanithaSampathBandara wants to merge 4 commits into
Conversation
JanithaSampathBandara
requested review from
Krishanx92,
lasanthaS,
piyumaldk and
tharikaGitHub
as code owners
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR changes validation and endpoint-test error handling across five components to prefer server response body fields ( ChangesError Message Enrichment in Validation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
JanithaSampathBandara seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@portals/publisher/src/main/webapp/source/src/app/components/Apis/Create/OpenAPI/Steps/ProvideOpenAPI.jsx`:
- Around line 165-171: In the MCP server URL validation catch block inside
ProvideOpenAPI.jsx update the error selection so it mirrors the non‑MCP path:
when calling setValidity({ url: { message: ... } }) use the chain
error.response?.body?.description || error.response?.body?.message ||
error.message instead of jumping directly from description to error.message;
locate the catch handler that calls setValidity, onValidate(false),
setIsValidating(false) and replace the message expression to include the
intermediate error.response?.body?.message fallback.
In
`@portals/publisher/src/main/webapp/source/src/app/components/MCPServers/Create/MCPServerCreateProxy.jsx`:
- Around line 234-239: The fallback hardcoded string assigned to errorMessage
bypasses i18n; replace the literal 'Failed to validate MCP Server URL' with a
call to intl.formatMessage (using an existing message id or add a new one) when
constructing errorMessage so that setValidationError receives a localized string
(ensure intl is in scope in MCPServerCreateProxy.jsx and keep the existing
precedence of error.response.body.description || error.response.body.message ||
intl.formatMessage(...)); this will ensure the validationError shown to the user
is localized.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ba807d46-e7f5-49af-bea9-aa4026db48d6
📒 Files selected for processing (5)
portals/publisher/src/main/webapp/source/src/app/components/Apis/Create/AsyncAPI/Steps/ProvideAsyncAPI.jsxportals/publisher/src/main/webapp/source/src/app/components/Apis/Create/Components/DefaultAPIForm.jsxportals/publisher/src/main/webapp/source/src/app/components/Apis/Create/GraphQL/Steps/ProvideGraphQL.jsxportals/publisher/src/main/webapp/source/src/app/components/Apis/Create/OpenAPI/Steps/ProvideOpenAPI.jsxportals/publisher/src/main/webapp/source/src/app/components/MCPServers/Create/MCPServerCreateProxy.jsx
added 2 commits
May 9, 2026 01:31
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds UI improvements related to the outbound request security feature introduced to mitigate Server-Side Request Forgery (SSRF) attacks.
Previously, outbound request validation failures could surface as generic HTTP errors in the UI, making it difficult for users to understand the actual validation issue.
This improvement provides clearer validation feedback for blocked or untrusted remote URLs.
Goals
Approach
Updated UI components responsible for endpoint validation to properly extract and display backend validation errors returned by outbound request security checks.
Improved:
Handled scenarios including:
Release Note
Improved UI error handling for outbound request security validation failures.
Testing
Verified: