Skip to content

Update role and permission mappings in Helm chart and role-to-scope mapping filr - #3125

Merged
Thushani-Jayasekera merged 2 commits into
wso2:mainfrom
Thushani-Jayasekera:fallback-remove
Aug 4, 2026
Merged

Update role and permission mappings in Helm chart and role-to-scope mapping filr#3125
Thushani-Jayasekera merged 2 commits into
wso2:mainfrom
Thushani-Jayasekera:fallback-remove

Conversation

@Thushani-Jayasekera

Copy link
Copy Markdown
Contributor

Update role and permission mappings in Helm chart and role-to-scope mapping files to include new API management permissions and adjust existing ones for llm_provider.

…apping files to include new API management permissions and adjust existing ones for llm_provider.
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@Thushani-Jayasekera, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 12059466-b114-4170-bc47-5be83c637ae2

📥 Commits

Reviewing files that changed from the base of the PR and between 2d44a34 and 300e818.

📒 Files selected for processing (2)
  • kubernetes/helm/platform-api-helm-chart/values.yaml
  • platform-api/resources/role-to-scope-mapping.yaml
📝 Walkthrough

Walkthrough

The PR expands ap_admin permissions across gateway, REST API, application, LLM, and MCP resources. It changes the ap_publisher LLM provider permission from management to read access.

Changes

Authorization scope configuration

Layer / File(s) Summary
Role permission updates
kubernetes/helm/platform-api-helm-chart/values.yaml, platform-api/resources/role-to-scope-mapping.yaml
The ap_admin role gains additional management scopes. The ap_publisher role changes from ap:llm_provider:manage to ap:llm_provider:read.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: renuka-fernando, malinthaprasan

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the change but omits nearly all required template sections, including purpose, goals, approach, tests, security checks, and test environment. Complete the required sections and document the purpose, goals, approach, user stories, documentation impact, tests, security checks, samples, related PRs, and test environment.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the role and permission mapping changes, although it contains a typo in “filr.”
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@platform-api/resources/role-to-scope-mapping.yaml`:
- Line 164: The `ap_publisher` role comment at lines 151-152 describes full LLM
lifecycle ownership, but the permission on line 164 has been changed from
`ap:llm_provider:manage` to `ap:llm_provider:read`, indicating the role now has
read-only access to LLM providers rather than full management. Update the
`ap_publisher` role description to accurately reflect that the role can read LLM
providers and manage provider deployments, removing the claim of owning the full
LLM lifecycle.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5a73c193-11ba-4aff-bfbd-d365b4c83f49

📥 Commits

Reviewing files that changed from the base of the PR and between 8d7c3bb and 2d44a34.

📒 Files selected for processing (2)
  • kubernetes/helm/platform-api-helm-chart/values.yaml
  • platform-api/resources/role-to-scope-mapping.yaml

Comment thread platform-api/resources/role-to-scope-mapping.yaml
renuka-fernando
renuka-fernando previously approved these changes Aug 4, 2026
…mapping files, consolidating llm_provider permissions and clarifying scope definitions for better management and access control.
@Thushani-Jayasekera
Thushani-Jayasekera merged commit 4bca0ae into wso2:main Aug 4, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants