Skip to content

Style CLI login callback pages to match the console theme - #1506

Open
jhivandb wants to merge 1 commit into
wso2:mainfrom
jhivandb:style-cli-login-pages
Open

Style CLI login callback pages to match the console theme#1506
jhivandb wants to merge 1 commit into
wso2:mainfrom
jhivandb:style-cli-login-pages

Conversation

@jhivandb

@jhivandb jhivandb commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

For:

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter �N/A� plus brief explanation of why there�s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type �Sent� when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type �N/A� and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Summary by CodeRabbit

  • User Experience Improvements
    • Added responsive success and error pages for the sign-in flow.
    • Added light and dark theme support with clear status icons.
    • Improved handling and display of authorization error messages.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f0e26d61-afae-4a95-b15a-db8b3ea95a38

📥 Commits

Reviewing files that changed from the base of the PR and between 045dd22 and 28afc06.

📒 Files selected for processing (2)
  • cli/pkg/auth/login_page.go
  • cli/pkg/auth/pkce.go

📝 Walkthrough

Walkthrough

The change adds a shared themed login page with escaped messages and responsive light/dark styling. The PKCE callback handler uses the page helpers for success and error responses while preserving existing status codes and callback errors.

Changes

Login page rendering

Layer / File(s) Summary
Shared login page template
cli/pkg/auth/login_page.go
Adds responsive success and error page markup, status icons, light/dark styles, rendering helpers, and HTML-escaped messages.
PKCE callback integration
cli/pkg/auth/pkce.go
Sets the HTML content type and routes state mismatches, authorization errors, missing codes, and successful callbacks through the shared renderers. Removes the inline templates and unused import.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CallbackHandler
  participant LoginPageRenderer
  participant Browser
  CallbackHandler->>LoginPageRenderer: render success or error page
  LoginPageRenderer-->>CallbackHandler: return themed HTML
  CallbackHandler->>Browser: write HTML response
Loading
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes the purpose and issue reference, but most required sections contain only template instructions and no project-specific details. Complete the required sections with the goals, approach, UI evidence, testing, security checks, documentation impact, release note, and other applicable details.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating CLI login callback pages to match the console theme.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants