[pull] develop from mikepenz:develop#5
Merged
Conversation
The `com.github.skydoves.compose.stability.analyzer` plugin unconditionally
adds `com.github.skydoves:compose-stability-runtime` as an `implementation`
dependency. Applying it to the published modules put that artifact into their
`runtimeElements` variant, so it landed in the POM with `<scope>runtime</scope>`
and every consumer pulled it onto their runtime classpath.
The analyzer is a development tool (recomposition tracing). Its runtime API is
not referenced anywhere in this repo, and none of the published classes contain
a reference to `com/skydoves/compose/stability` - the dependency was dead weight
for consumers.
Drop the plugin from the four published modules and keep it on `app`, where the
tracing is actually used. The `composeCompiler { stabilityConfigurationFiles }`
blocks are Compose compiler configuration and are unaffected.
Affects 14.0.0-a01 through 15.0.3.
Fixes #1424
…-leak fix(build): stop leaking compose-stability-runtime into consumers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )