Skip to content

fix(revit): scope the PushButtonData release with a using on the IDisposable view #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewrz merged 1 commit into from
Oct 6, 2026
Merged

fix(revit): scope the PushButtonData release with a using on the IDisposable view #712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions revit-addin/App.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,14 @@ public Result OnStartup(UIControlledApplication application)
$"Calls SpecR at the URL in the {SpecRClient.BaseUrlEnvVar} environment " +
$"variable (default {SpecRClient.DefaultBaseUrl}).",
};
try
{
panel.AddItem(buttonData);
return Result.Succeeded;
}
finally
{
// From Revit 2025 the ribbon data classes are disposable API
// wrappers (Revit 2024's are not); the panel has copied what it
// needs in AddItem, so release the data object either way without
// a per-version #if (CodeQL cs/local-not-disposed).
(buttonData as IDisposable)?.Dispose();
}
// From Revit 2025 the ribbon data classes are disposable API wrappers
// (Revit 2024's are not): release the data object at the end of this
// scope on the legs where it is one, with a single code path for all
// of them. The panel copies what it needs in AddItem.
using var releaseButtonData = buttonData as IDisposable;

panel.AddItem(buttonData);
return Result.Succeeded;
}
catch (Exception ex) when (ex is Autodesk.Revit.Exceptions.ApplicationException
|| ex is InvalidOperationException)
Expand Down
Loading