Skip to content

Don't enqueue abus_script if user isn't logged in#13

Open
widoz wants to merge 3 commits into
wpmark:masterfrom
widoz:patch-1
Open

Don't enqueue abus_script if user isn't logged in#13
widoz wants to merge 3 commits into
wpmark:masterfrom
widoz:patch-1

Conversation

@widoz

@widoz widoz commented Mar 16, 2017

Copy link
Copy Markdown

There is a reason why the script is enqueued even for non logged in users?

By the way, there is no need to enqueue 'jquery' since it is defined as depency.

There is a reason why the script is enqueued even for non logged in users?

By the way, there is no need to enqueue 'jquery' since it is defined as depency.
@wpmark

wpmark commented Mar 22, 2017

Copy link
Copy Markdown
Owner

Thanks for this @widoz it looks good to me and makes sense. Could you bump the version and add the changes to the changelog please and then I will merge. Thanks.

@widoz

widoz commented Mar 23, 2017

Copy link
Copy Markdown
Author

Hope I did it correctly.

Thank you so much.

@widoz

widoz commented Mar 23, 2017

Copy link
Copy Markdown
Author

I must change even the Stable Tag?

@mundschenk-at

Copy link
Copy Markdown

@wpmark: Why did you not simply merge #12? That PR would have disabled unnecessary script registration AND styles enqueuing. If necessary, I could have produced a commit without the trailing whitespace removal.

@widoz

widoz commented Apr 2, 2017

Copy link
Copy Markdown
Author

@mundschenk-at Effectively it's a better solution.
+1 for that.

Regarding the code style may I suggest to implement the wpcs ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants