Don't enqueue abus_script if user isn't logged in#13
Open
widoz wants to merge 3 commits into
Open
Conversation
There is a reason why the script is enqueued even for non logged in users? By the way, there is no need to enqueue 'jquery' since it is defined as depency.
Owner
|
Thanks for this @widoz it looks good to me and makes sense. Could you bump the version and add the changes to the changelog please and then I will merge. Thanks. |
Author
|
Hope I did it correctly. Thank you so much. |
Author
|
I must change even the Stable Tag? |
Author
|
@mundschenk-at Effectively it's a better solution. Regarding the code style may I suggest to implement the wpcs ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a reason why the script is enqueued even for non logged in users?
By the way, there is no need to enqueue 'jquery' since it is defined as depency.