Skip to content

Fix newly reported PHPStan errors - #159

Merged
swissspidy merged 1 commit into
mainfrom
fix/phpstan
Aug 6, 2026
Merged

Fix newly reported PHPStan errors#159
swissspidy merged 1 commit into
mainfrom
fix/phpstan

Conversation

@swissspidy

@swissspidy swissspidy commented Aug 6, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Documentation
    • Added inline documentation clarifying the expected structure of plugin version data.

Copilot AI lite review requested due to automatic review settings August 6, 2026 09:02
@swissspidy
swissspidy requested a review from a team as a code owner August 6, 2026 09:02
@swissspidy swissspidy added the scope:testing Related to testing label Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 59efdf20-68a0-4ddc-b90d-60385a971450

📥 Commits

Reviewing files that changed from the base of the PR and between 5182844 and be8a678.

📒 Files selected for processing (1)
  • src/Checksum_Plugin_Command.php

📝 Walkthrough

Walkthrough

The change adds a PHPDoc array-shape annotation for $plugin_data. The annotation documents a string version field.

Changes

Plugin data annotation

Layer / File(s) Summary
Document plugin data shape
src/Checksum_Plugin_Command.php
The PHPDoc now specifies that $plugin_data contains a string version field.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the PHPDoc change made to resolve newly reported PHPStan errors.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/phpstan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses newly reported PHPStan type issues by adding an inline type assertion for the WordPress.org plugin info response, clarifying the expected structure of the plugin version data within the WP-CLI checksum command.

Changes:

  • Added a PHPDoc @var array-shape annotation to assert $plugin_data contains a version: string key after runtime validation.
  • Helps PHPStan understand $plugin_data['version'] is a string when used as a fallback version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy added this to the 3.0.1 milestone Aug 6, 2026
@swissspidy
swissspidy merged commit 57c87df into main Aug 6, 2026
67 of 68 checks passed
@swissspidy
swissspidy deleted the fix/phpstan branch August 6, 2026 09:31
@swissspidy
swissspidy restored the fix/phpstan branch August 6, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants