Skip to content

fix(cluster): apply AlphaFloor in dial calibration sweep - #788

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/alphafloor-dial-calibration
Open

fix(cluster): apply AlphaFloor in dial calibration sweep#788
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/alphafloor-dial-calibration

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

computeDialCalibration swept raw alpha values without applying AlphaFloor, so breakpoints included mix changes at alphas the dial can never reach (floored slots hold at floor[i]), producing long dead zones on floored bundles (e.g. v0.73). The sweep now shares the flooring with applyDialAlpha via a new applyAlphaFloor(alpha, raw, floor) helper (alpha[i] = max(raw, floor[i]), nil floor disables), so breakpoints exclude unreachable low-alpha regions.

Tests: floored-bundle (v0.73) variants of the no-dead-zone and mid-dial-pricier distribution guards, direct applyAlphaFloor coverage, and breakpoint checks that no interior breakpoint falls below min(AlphaFloor) (committed bundle + heterogeneous-floor synthetic).

Adapted from #781 by @rohith500 (logic unchanged; comments reworked to match repo conventions).

Link to Devin session: https://app.devin.ai/sessions/75cb14caa09442c6a0ca9116059ed63f
Requested by: @steventohme

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Jul 18, 2026

Copy link
Copy Markdown

PR author is not in the allowed authors list.

@claude

claude Bot commented Jul 18, 2026

Copy link
Copy Markdown

Claude finished @devin-ai-integration[bot]'s task —— View job


No comment-length issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant