fix(cluster): apply AlphaFloor in dial calibration sweep - #788
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix(cluster): apply AlphaFloor in dial calibration sweep#788devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
PR author is not in the allowed authors list. |
|
Claude finished @devin-ai-integration[bot]'s task —— View job No comment-length issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
computeDialCalibrationswept raw alpha values without applyingAlphaFloor, so breakpoints included mix changes at alphas the dial can never reach (floored slots hold atfloor[i]), producing long dead zones on floored bundles (e.g. v0.73). The sweep now shares the flooring withapplyDialAlphavia a newapplyAlphaFloor(alpha, raw, floor)helper (alpha[i] = max(raw, floor[i]), nil floor disables), so breakpoints exclude unreachable low-alpha regions.Tests: floored-bundle (v0.73) variants of the no-dead-zone and mid-dial-pricier distribution guards, direct
applyAlphaFloorcoverage, and breakpoint checks that no interior breakpoint falls belowmin(AlphaFloor)(committed bundle + heterogeneous-floor synthetic).Adapted from #781 by @rohith500 (logic unchanged; comments reworked to match repo conventions).
Link to Devin session: https://app.devin.ai/sessions/75cb14caa09442c6a0ca9116059ed63f
Requested by: @steventohme