ci(macos): sticky legacy-peer-deps via .npmrc#46
Merged
Conversation
The macOS CI job (added in #42) fails at npm install with ERESOLVE — react-native-webview peers on react-native-macos, conflicting with the app's direct react-native pin. Add .npmrc with legacy-peer-deps=true so the setting is sticky regardless of npm version or invocation path. This is what macos:install already passes via --legacy-peer-deps; making it a file means CI's plain npm ci/install picks it up too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS CI job added in #42 fails at
npm installwith ERESOLVE — react-native-webview peers on react-native-macos, conflicting with the app's direct react-native pin. Addsexample/macos-app/.npmrcwithlegacy-peer-deps=trueso the setting is honoured regardless of how npm is invoked (CI uses plainnpm ciwhich doesn't get the--legacy-peer-depsflag thatmacos:installpasses).Follow-up fix for the macOS CI job; no library code change.