chore: set up CI (typecheck + lint + test on PR and push)#28
Open
LeslieOA wants to merge 1 commit into
Open
Conversation
GitHub Actions workflow at .github/workflows/ci.yml. Runs on every PR against develop and every push to develop. Three parallel jobs: typecheck (tsc --noEmit), lint (eslint src), test (jest). Node 20 matches package.json's engines field and Workspace's toolchain. Single Node version on purpose — adding a 22/24 matrix triples runner minutes for negligible value at this scale. Concurrency group cancels superseded runs on the same PR ref. Pushes to develop don't cancel (they should always complete to publish status). Manual follow-up (can't encode in repo): set up branch protection on develop requiring Typecheck / Lint / Test contexts before merge. Command in the PR description. Refs: #8 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three parallel jobs (typecheck, lint, test) on every PR against
developand every push todevelop. Node 20, npm ci with cache, no matrix.What's NOT in this PR (manual follow-up)
Branch protection on
developrequiring all three checks to pass before merge. Can't be encoded in the repo — has to be set via the repo settings UI or:I'd leave
enforce_admins: falseso genuine emergency force-merges by the maintainer don't require disabling protection first.What CI will actually run
On
developHEAD right now: 38/38 tests, clean typecheck, lint exit 0. So this PR should be green on its first run. Once merged, every subsequent PR (starting with #27) gets the same gate.Concurrency
Superseded PR runs cancel automatically — saves runner minutes during review cycles. Pushes to
developdon't cancel; they complete to publish status correctly.Test plan
Refs: #8