Release 1.40.0 by cameronvoell · Pull Request #2758 · wordpress-mobile/gutenberg-mobile

cameronvoell · 2020-10-26T18:51:31Z

Release for Gutenberg Mobile 1.40.0

Related PRs

Gutenberg: Mobile Release v1.40.0 WordPress/gutenberg#26466
WPAndroid: Integrate gutenberg-mobile release 1.40.0 WordPress-Android#13236
WPiOS: Integrate gutenberg-mobile release 1.40.0 WordPress-iOS#15166
Aztec-iOS: N/A
Aztec-Android: N/A

Extra PRs that Landed After the Release Was Cut

Fix for CI - [RNMobile] Fix CI issues during npm ci WordPress/gutenberg#26455
Fix for wrong Android emulator on CI - Pin circleci/android:api-29-node docker image to previous version with node 12 #2763

Changes

Media Files error handling: Media Files Collection (part4: error handling) WordPress/gutenberg#26008 (review)
Add yarn to prerequisites: Add Yarn to README Prerequisites #2739
Adjust media-text attributes to defaul stacked on mobile to true: Adjust media-text attributes to default stacked on mobile to true WordPress/gutenberg#26041

Test plan

Use the main WP apps to test the changes above.
Smoke test the main WP apps for general writing flow.

Release Submission Checklist

Approve and run optional Android and iOS UI tests
Aztec dependencies are pointing to a stable release.
- iOS: Aztec dependencies match in RNTAztecView.podspec and gutenberg/packages/react-native-aztec/RNTAztecView.podspec.
Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
Bundle package of the release is updated.

…ility

…tion files

…ility

…_bundle_files Remove auto-generated files from bundle and add to .gitignore

…k_inserter_accessibility Improve block inserter accessibility

# Please enter the commit message for your changes. Lines starting

…pdate Update Jetpack ref

) * Update guteneberg * Revert Jetpack change

This project now requires both npm and yarn because Jetpack uses yarn.

…requisites Add Yarn to README Prerequisites

…o_develop Merge release 1.39.0 to develop

It's already automated by the script

…bile

Move release scripts and improve checklists

…o_develop Merge release 1.39.1 to develop

peril-wordpress-mobile · 2020-10-26T18:51:37Z

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

antonis · 2020-10-27T11:28:41Z

iOS Sanity Testing Results

Tested with build number: 36877 from App Center on a iPhone SE 2020 with iOS 14.2

DarkMode-2

Spacer block - Dark mode - steps
Buttons block - Dark mode - steps
Group - Dark mode - steps
Columns - Dark mode - steps

Group-2

Group - Navigation up button works as expected - steps
Group - Navigation down works according to parent-first approach - steps
Group - Cross navigation between blocks works as expected - steps
Group - Ungroup button works as expected - steps
Group - Check if in DarkMode all components gets proper colors - steps
Group - Check if nested Placeholder block can be replaced - steps

Spacer-2

Spacer block - Settings: Available height range is correct - steps

The slider allows to minimum value of 1px. The same holds true for the Web.

This seems to be an intentional change and the test case needs to be updated.

Mobile	Web

Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - steps

When setting this in HTML it produces an error on mobile. On the web this seems to work sometimes (like below) but not consistently

Opened #2761 to track this

Web	HTML	Mobile

Spacer block - Spacer in horizontal layout works as expected - steps

Buttons-4

Buttons block - Render custom text color - steps
Buttons block - Render custom background color - steps
Buttons block - Render gradient background color - steps
Buttons block - Check if selection / caret color matches font color - steps
Buttons block - The newly created Buttons has set background color to the theme-default color in preview - steps

Button-5

Buttons block - Edit text styles - steps
Buttons block - Render theme colors - steps
Buttons block - Settings: Change Button border radius - steps

Button-7

Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - steps
Buttons block - Toolbar link button is active when Button has link - steps

Editor Theme - 2

Custom Gradients - Check that custom gradients load in the editor - steps
Offline Support - steps

Color Settings - 2

Pressing color swatch - steps
Customize gradient color - steps
Custom color picker - steps

cameronvoell · 2020-10-28T00:40:12Z

ceyhun · 2020-10-29T11:03:55Z

cameronvoell · 2020-10-29T14:54:29Z

cameronvoell · 2020-10-29T14:58:10Z

Thanks @ceyhun and @antonis for the tests! Looks like we're all green except some minor behavior around setting spacer height outside the allowed range through html which @antonis create a ticket for (thank you!). Looks good to go from my perspective 👍

ceyhun

…image Pin circleci/android:api-29-node docker image to previous version with node 12

jd-alexander and others added 30 commits September 22, 2020 18:03

update gutenberg ref.

761d023

Update gutenberg ref

04fe2e5

Updated ref.

98c7ba0

Merge branch 'develop' into issue-915/improve_block_inserter_accessib…

6f0ce32

…ility

Remove files under bundle/android/raw and add to .gitignore

4ea4507

Try removing ios bundle assets files and adding to .gitignore

76b2584

Remove autogenerated files from source control

4e79401

Merge branch 'develop' into issue-915/improve_block_inserter_accessib…

a62102f

…ility

Updated ref.

8344676

Merge branch 'develop' into fix/2693_remove_unused_bundle_files

9188571

Fix gutenberg ref after merge

ec9f1d1

Limit .gitignore to block.json files and don't exclude assets transla…

62a14e8

…tion files

Merge branch 'develop' into issue-915/improve_block_inserter_accessib…

7e8c427

…ility

Merge branch 'develop' into issue-915/improve_block_inserter_accessib…

bd9ff93

…ility

Merge pull request #2694 from wordpress-mobile/fix/2693_remove_unused…

98cbed7

…_bundle_files Remove auto-generated files from bundle and add to .gitignore

Merge pull request #2655 from wordpress-mobile/issue-915/improve_bloc…

cf06fd7

…k_inserter_accessibility Improve block inserter accessibility

Update Jetpack ref

bc4be69

Add yarn install inside jetpack submodule after npm install

1135316

Ignoring engines in Jetpack yarn install

2f04c27

# Please enter the commit message for your changes. Lines starting

Update gutenberg ref

7c5f992

Update gutenberg ref

c48f792

Update gutenberg ref

d1c6980

Merge pull request #2729 from wordpress-mobile/contact-form-jetpack-u…

f4ef7bf

…pdate Update Jetpack ref

Merge branch 'develop' into merge_release_1.39.0_to_develop

b144d13

Update gutenberg ref

85820cf

Adjust media-text attributes to default stacked on mobile to true (#2712

e7deb98

) * Update guteneberg * Revert Jetpack change

Add Yarn to Readme Prerequisites

31bc585

This project now requires both npm and yarn because Jetpack uses yarn.

Merge pull request #2739 from wordpress-mobile/add_yarn_to_readme_pre…

31088a0

…requisites Add Yarn to README Prerequisites

Merge branch 'develop' into merge_release_1.39.0_to_develop

c6d7abe

Merge pull request #2734 from wordpress-mobile/merge_release_1.39.0_t…

92bff7e

…o_develop Merge release 1.39.0 to develop

ceyhun and others added 12 commits October 21, 2020 18:02

Remove Podfile.lock related check from release PR template

0352cd6

It's already automated by the script

Add option to cherry-pick a commit from gutenberg before bundling

2259693

Separate commit messages for bundle and gutenberg ref update

f3caed7

Add steps to bring release changes back to development branches

721ace9

Merge branch 'develop' into merge_release_1.39.1_to_develop

ebd9051

Move release scripts to wordpress-mobile/release-toolkit-gutenberg-mo…

ee85404

…bile

Merge pull request #2755 from wordpress-mobile/improve-release-script

6953375

Move release scripts and improve checklists

Update Jetpack ref

b3c18aa

Merge pull request #2754 from wordpress-mobile/merge_release_1.39.1_t…

4a6ed2c

…o_develop Merge release 1.39.1 to develop

Release script: Update gb mobile version to 1.40.0

e001f0e

Release script: Update gutenberg ref

5e50fff

Release script: Update bundle for: 1.40.0

801d4d8

cameronvoell added the release-process label Oct 26, 2020

This was referenced Oct 26, 2020

Mobile Release v1.40.0 WordPress/gutenberg#26466

Merged

Integrate gutenberg-mobile release 1.40.0 wordpress-mobile/WordPress-Android#13236

Merged

Integrate gutenberg-mobile release 1.40.0 wordpress-mobile/WordPress-iOS#15166

Merged

Updated gutenberg ref for CI fix

b5da3a3

cameronvoell marked this pull request as ready for review October 27, 2020 00:38

antonis mentioned this pull request Oct 27, 2020

Spacer fails to render when height is set > 500px #2761

Closed

ceyhun approved these changes Oct 29, 2020

View reviewed changes

cameronvoell added 2 commits October 29, 2020 14:37

Updated bundle

b8280f2

Merge pull request #2763 from wordpress-mobile/fix/ci-android-docker-…

06516db

…image Pin circleci/android:api-29-node docker image to previous version with node 12

cameronvoell merged commit f9c2027 into trunk Oct 29, 2020

cameronvoell deleted the release/1.40.0 branch October 29, 2020 23:55

Navigation Menu

Uh oh!

Release 1.40.0 - #2758

Release 1.40.0#2758
cameronvoell merged 48 commits into
trunkfrom
release/1.40.0

cameronvoell commented Oct 26, 2020 •

edited

Loading

Uh oh!

peril-wordpress-mobile Bot commented Oct 26, 2020 •

edited

Loading

Uh oh!

antonis commented Oct 27, 2020 •

edited

Loading

Uh oh!

cameronvoell commented Oct 28, 2020 •

edited

Loading

Uh oh!

ceyhun commented Oct 29, 2020

Uh oh!

cameronvoell commented Oct 29, 2020

Uh oh!

cameronvoell commented Oct 29, 2020

Uh oh!

ceyhun left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

cameronvoell commented Oct 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

Test plan

Release Submission Checklist

Uh oh!

peril-wordpress-mobile Bot commented Oct 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antonis commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS Sanity Testing Results

DarkMode-2

Group-2

Spacer-2

Buttons-4

Button-5

Button-7

Editor Theme - 2

Color Settings - 2

Uh oh!

cameronvoell commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ceyhun commented Oct 29, 2020

Uh oh!

cameronvoell commented Oct 29, 2020

Uh oh!

cameronvoell commented Oct 29, 2020

Uh oh!

ceyhun left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cameronvoell commented Oct 26, 2020 •

edited

Loading

peril-wordpress-mobile Bot commented Oct 26, 2020 •

edited

Loading

antonis commented Oct 27, 2020 •

edited

Loading

cameronvoell commented Oct 28, 2020 •

edited

Loading