Use checkout_release_branch from a8c-ci-toolkit - #23179
Draft
AliSoftware wants to merge 1 commit into
Draft
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
Thirteen repos each carried a byte-identical copy of `.buildkite/commands/checkout-release-branch.sh`. It now lives in `a8c-ci-toolkit` instead, as the `checkout_release_branch` command, so there is one copy to fix the next time it needs fixing. Behaviour is unchanged. The toolkit pin moves from 5.3.1 to 6.3.0, the release that introduces the command.
AliSoftware
force-pushed
the
ainfra-2828-use-toolkit-checkout-release-branch
branch
from
August 6, 2026 19:43
d24bd18 to
a279d39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes AINFRA-2828
Why?
.buildkite/commands/checkout-release-branch.shscript to byte-identical copies across 13 repos.a8c-ci-toolkitas thecheckout_release_branchcommand, so there is a single source of truth for its implementation.How?
Behaviour is unchanged — the command in
a8c-ci-toolkitis a straight port of the script being deleted here.Every call site already runs in a step with the toolkit plugin loaded, which is what puts the command on
$PATH.Compatibility
The toolkit pin moves from
5.3.1to6.3.0. I checked the breaking changes in the toolkit'sCHANGELOG.mdbetween those two versions and none apply to this repo.Draft Status
Important
Draft until
a8c-ci-toolkit6.3.0is released — the pin doesn't resolve before then.