Add per-raw-hit calibration fields, separate clean offset, and update TDC bin comment#11
Open
wooyeonkwon wants to merge 3 commits into
Open
Add per-raw-hit calibration fields, separate clean offset, and update TDC bin comment#11wooyeonkwon wants to merge 3 commits into
wooyeonkwon wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
offsetandtdc_cali_rawvectors toEventBuffersand created corresponding output branchesoffsetandtdc_cali_rawto store per-raw-hit Gaussian mean and calibrated raw time (computed asrec.tdc - offset).offsetvector for clean hits tooffset_cleanto avoid reusing the same container for raw and clean values, and created theoffset_cleanbranch.offsetandtdc_cali_rawearlier so every raw hit gets a stored calibration value regardless of clean selection, and retained the clean-selection logic that fillsch,tdc, andclean_rawIndexusingoffset_clean.1000to20000units and adjusted bounds checks for channel mapping againstcalibration.offsets.Testing
g++ -O2 -std=c++17 main_mRPC.cc \\root-config --cflags --libs`` and the build completed successfully.Eventstree contains the newoffset,tdc_cali_raw, andoffset_cleanbranches and that execution completed without errors.Codex Task