fix(android): preserve encoded content URIs - #1040
Open
ngocdevv wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content://source URIs exactly as received.file://and other local paths, retaining support for encoded spaces and accented filenames.Problem
Android scoped URI permissions are keyed by the exact URI. The current local-source path runs every URI through
decodeURIComponent, so a granted URI such as:becomes
.../msf:6179before it reachesContentResolver. That no longer matches the temporary permission granted by Android.Fix
Detect
content://sources before normalizing the local path and pass those URIs through unchanged. All non-content local sources keep the existing decoding behavior, including the accented-filename fix from #873.Testing
Pdf#_prepareFile:content://.../msf%3A6179remains byte-for-byte unchanged.file:///documents/R%C3%A9sum%C3%A9%20final.pdfstill becomes/documents/Résumé final.pdf.node --check index.jsgit diff --checknpm pack --dry-run --ignore-scriptsCloses #990.