[VENDOR][FIX] Persist the vendor-to-discovered-license link (#27) - #28
Merged
Merged
Conversation
Slice 2's resolution recorded only the vendor's input eVP license and dropped the board-confirmed License_Number it discovered on a name match. So a name-matched vendor (whose eVP license was blank or out-of-state) could not be linked to its real license from the persisted output, blocking slice 3's reconciliation. Capture the decoded License_Number as Resolution.discovered_license and write it into resolution-report.json; the acquire loop now decodes the record before recording the resolution. Regression test added first, then the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27.
Problem. Slice 2's
Resolution/resolution-report.jsonstored only the vendor's input eVP license and dropped the board-confirmedLicense_Numberdiscovered on a name match. A name-matched vendor (blank/out-of-state eVP license) therefore had no persisted link to its real license — blocking slice 3's reconciliation (V2 indocs/requirements-validation.md).Fix. Capture the decoded
License_NumberasResolution.discovered_licenseand write it intoresolution-report.json. The acquire loop now decodes the matched record before recording the resolution.data/is untouched; this is acquire-shell only.Tests. Regression test added first (
test_resolution_carries_discovered_license), then the fix. Full suite 79 passed / 2 skipped, ruff + format clean, pyright 0.Unblocks slice 3 (the reconciliation deliverable).