[WIP]Data schema generation #13
Draft
FanG-817 wants to merge 11 commits into
Draft
Conversation
commit 3196018 Author: Shane Duan <18065+wolfdancer@users.noreply.github.com> Date: Thu Nov 27 19:18:56 2025 -0800 Fix requirements.txt to use --find-links for Rockfish SDK installation (wolfdancer#14) Changed from --extra-index-url to --find-links in requirements.txt to properly install the rockfish SDK from the custom package repository at https://packages.rockfish.ai. Also updated CLAUDE.md to document this requirement and added .claude/ to .gitignore. Fixes wolfdancer#9 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Shane <wolfdancer@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> commit 2c686cc Author: Shane Duan <18065+wolfdancer@users.noreply.github.com> Date: Wed Nov 26 13:32:52 2025 -0800 Remove query_dataset tool from MCP server as the execute_query tool can do the same job and work with LLM much better.More specifically, the query_dataset requires the table name to be "my_table", which LLM is just not used to. Instead, execute_query uses the dataset id as the table name, and that works out of box with LLM. (wolfdancer#11) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com> commit b22e44b Merge: 0260809 b129acf Author: Shane Duan <18065+wolfdancer@users.noreply.github.com> Date: Tue Nov 25 19:34:01 2025 -0800 Merge pull request wolfdancer#7 from FanG-817/feature/workflow_rf_tab_gan Add SDK synthetic data generation workflow commit 0260809 Merge: c5ba902 81d51be Author: Shane Duan <18065+wolfdancer@users.noreply.github.com> Date: Mon Nov 24 20:05:50 2025 -0800 Merge pull request wolfdancer#6 from FanG-817/refactor/standardize-api-url-naming update all "base_url" to "api_url" with backward compatibility as part of the deprecation process
Contributor
Author
|
I have updated extracting and parsing the structure error: rockfish-mcp/src/rockfish_mcp/sdk_client.py Lines 689 to 788 in 34c74ae It helps a lot for self-correction by understanding the exact error. |
Contributor
Author
|
Additional validation tickets are created in rockfish repo. We have been adding missing validations so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR currently works. I continue improving the validation part.
Some good suggestions from @amad-person that might help to provide more error information for self-correction: