Removes the legacy ASN parser override (WOLFSSL_ASN_ORIGINAL) from …#10581
Removes the legacy ASN parser override (WOLFSSL_ASN_ORIGINAL) from …#10581miyazakh wants to merge 2 commits into
WOLFSSL_ASN_ORIGINAL) from …#10581Conversation
…the RA6M4 demo project
There was a problem hiding this comment.
Pull request overview
This PR updates the Renesas RA6M4 e2studio demo to rely on the current wolfSSL ASN.1 parser (by removing the project-level WOLFSSL_ASN_ORIGINAL override), cleans up now-dead legacy ASN parsing code, refreshes SCE certificate signature test data, and corrects RA6M4 README guidance.
Changes:
- Remove
WOLFSSL_ASN_ORIGINALfrom the RA6M4 demo’suser_settings.hso the project uses the current ASN parser. - Delete the unused
RsaPublicKeyDecodeRawIndex()helper fromwolfcrypt/src/asn_orig.c. - Update pre-computed SCE signature buffers in
key_data_sce.cand fix several README instructions/values for the RA6M4 demo.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
wolfcrypt/src/asn_orig.c |
Removes an unused RSA public-key decode helper from the legacy ASN parser source. |
IDE/Renesas/e2studio/RA6M4/test/key_data/key_data_sce.c |
Refreshes the stored 256-byte SCE signature buffers for the demo’s CA certificate data. |
IDE/Renesas/e2studio/RA6M4/README.md |
Updates RA6M4 documentation (linker script name, RTT addresses, and IP configuration references). |
IDE/Renesas/e2studio/RA6M4/common/user_settings.h |
Drops the RA6M4-only WOLFSSL_ASN_ORIGINAL define so the current ASN parser is used. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10581
Scan targets checked: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
Renesas RA6M4: Remove WOLFSSL_ASN_ORIGINAL and update SCE certificate data
Summary
This PR removes the legacy ASN parser override (
WOLFSSL_ASN_ORIGINAL) from the RA6M4 demo project, cleans up the now-deadRsaPublicKeyDecodeRawIndex()function fromasn_orig.c, refreshes the pre-computed SCE certificate signature data, and corrects several inaccuracies in the README.Changes
IDE/Renesas/e2studio/RA6M4/common/user_settings.h#define WOLFSSL_ASN_ORIGINAL. The RA6M4 project now uses the current wolfSSL ASN parser instead of the legacy fallback.wolfcrypt/src/asn_orig.cRsaPublicKeyDecodeRawIndex()(compiled only underWOLFSSL_RENESAS_TSIP_TLSorWOLFSSL_RENESAS_FSPSM_TLS). This function became dead code onceWOLFSSL_ASN_ORIGINALwas removed from the project settings.IDE/Renesas/e2studio/RA6M4/test/key_data/key_data_sce.cca_cert_der_signandca_ecc_cert_der_signto match the renewed test CA certificates used by the RA6M4 demo.IDE/Renesas/e2studio/RA6M4/README.mdfsp.ld->fsp_gen.ld.0x20000000(was0x20023648/0x20023000).SERVER_IPconfiguration reference: points towolfssl_demo.hinstead ofwolf_client.c.Test Plan
test_RA6M4project in e2studio -- no errors expected withWOLFSSL_ASN_ORIGINALremoved.Checklist