Skip to content

Removes the legacy ASN parser override (WOLFSSL_ASN_ORIGINAL) from …#10581

Open
miyazakh wants to merge 2 commits into
wolfSSL:masterfrom
miyazakh:ra6m4_update
Open

Removes the legacy ASN parser override (WOLFSSL_ASN_ORIGINAL) from …#10581
miyazakh wants to merge 2 commits into
wolfSSL:masterfrom
miyazakh:ra6m4_update

Conversation

@miyazakh
Copy link
Copy Markdown
Contributor

@miyazakh miyazakh commented Jun 3, 2026

Renesas RA6M4: Remove WOLFSSL_ASN_ORIGINAL and update SCE certificate data

Summary

This PR removes the legacy ASN parser override (WOLFSSL_ASN_ORIGINAL) from the RA6M4 demo project, cleans up the now-dead RsaPublicKeyDecodeRawIndex() function from asn_orig.c, refreshes the pre-computed SCE certificate signature data, and corrects several inaccuracies in the README.


Changes

IDE/Renesas/e2studio/RA6M4/common/user_settings.h

  • Remove #define WOLFSSL_ASN_ORIGINAL. The RA6M4 project now uses the current wolfSSL ASN parser instead of the legacy fallback.

wolfcrypt/src/asn_orig.c

  • Remove the static helper RsaPublicKeyDecodeRawIndex() (compiled only under WOLFSSL_RENESAS_TSIP_TLS or WOLFSSL_RENESAS_FSPSM_TLS). This function became dead code once WOLFSSL_ASN_ORIGINAL was removed from the project settings.

IDE/Renesas/e2studio/RA6M4/test/key_data/key_data_sce.c

  • Update pre-computed SCE signature buffers ca_cert_der_sign and ca_ecc_cert_der_sign to match the renewed test CA certificates used by the RA6M4 demo.

IDE/Renesas/e2studio/RA6M4/README.md

  • Fix linker script filename: fsp.ld -> fsp_gen.ld.
  • Correct RTT control block address examples to 0x20000000 (was 0x20023648 / 0x20023000).
  • Fix SERVER_IP configuration reference: points to wolfssl_demo.h instead of wolf_client.c.

Test Plan

  • Build the test_RA6M4 project in e2studio -- no errors expected with WOLFSSL_ASN_ORIGINAL removed.
  • Flash to RA6M4 hardware and confirm TLS handshake succeeds with the updated SCE certificate signature data.
  • Verify both RSA and ECC certificate paths are handled correctly by the new ASN parser.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@miyazakh miyazakh self-assigned this Jun 3, 2026
Copilot AI review requested due to automatic review settings June 3, 2026 05:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Renesas RA6M4 e2studio demo to rely on the current wolfSSL ASN.1 parser (by removing the project-level WOLFSSL_ASN_ORIGINAL override), cleans up now-dead legacy ASN parsing code, refreshes SCE certificate signature test data, and corrects RA6M4 README guidance.

Changes:

  • Remove WOLFSSL_ASN_ORIGINAL from the RA6M4 demo’s user_settings.h so the project uses the current ASN parser.
  • Delete the unused RsaPublicKeyDecodeRawIndex() helper from wolfcrypt/src/asn_orig.c.
  • Update pre-computed SCE signature buffers in key_data_sce.c and fix several README instructions/values for the RA6M4 demo.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
wolfcrypt/src/asn_orig.c Removes an unused RSA public-key decode helper from the legacy ASN parser source.
IDE/Renesas/e2studio/RA6M4/test/key_data/key_data_sce.c Refreshes the stored 256-byte SCE signature buffers for the demo’s CA certificate data.
IDE/Renesas/e2studio/RA6M4/README.md Updates RA6M4 documentation (linker script name, RTT addresses, and IP configuration references).
IDE/Renesas/e2studio/RA6M4/common/user_settings.h Drops the RA6M4-only WOLFSSL_ASN_ORIGINAL define so the current ASN parser is used.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread IDE/Renesas/e2studio/RA6M4/README.md Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

MemBrowse Memory Report

No memory changes detected for:

Copy link
Copy Markdown

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10581

Scan targets checked: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread wolfcrypt/src/asn_orig.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants