Fix compilation with WOLFSSL_RNG_USE_FULL_SEED. Fix benchmark compilation with MAIN_NO_ARGS.#10577
Open
kareem-wolfssl wants to merge 2 commits into
Open
Fix compilation with WOLFSSL_RNG_USE_FULL_SEED. Fix benchmark compilation with MAIN_NO_ARGS.#10577kareem-wolfssl wants to merge 2 commits into
kareem-wolfssl wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a preprocessor-guard mismatch in wc_RNG initialization so builds with WOLFSSL_RNG_USE_FULL_SEED compile cleanly. The change is localized to the DRBG seed-size selection logic in the RNG initialization path.
Changes:
- Adjusted
#endifplacement so theWOLFSSL_RNG_USE_FULL_SEEDconditional only wraps theseedSzselection, not the subsequent declarations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kareem-wolfssl
changed the title
|
Contributor
Author
|
Retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#21907, zd#21874.
Testing
Built in tests
Checklist