Fix in IoTSafe RaspPi client example#10574
Open
embhorn wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the IoT-SAFE Raspberry Pi client example by reducing unsafe string handling when parsing CLI arguments and when constructing the HTTP POST request.
Changes:
- Add length checks before copying CLI argument strings into fixed-size buffers in
main.c. - Replace repeated
strcat()calls with a singlesnprintf()-based HTTP request construction in the TLS 1.3 client example.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| IDE/iotsafe-raspberrypi/main.c | Adds argument-length bounds checks before copying user-provided CLI values into local buffers. |
| IDE/iotsafe-raspberrypi/client-tls13.c | Replaces strcat-built HTTP request with snprintf and adds overflow detection for the request buffer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Harden example application by avoiding
strcatThanks to Ozidx(https://github.com/Ozidx) for reporting this issue.
Fixes zd21918
Testing
Customer confirmed
Checklist