support for dynamic link to libwolfssl and add test case#349
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #349
Scan targets checked: wolfhsm-core-bugs, wolfhsm-src
No new issues found in the changed files. ✅
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds a new WOLFSSL_LIB=1 build mode so several targets can link against an installed libwolfssl instead of compiling wolfSSL sources from the tree, and adds CI coverage for that path. It also updates certificate parsing to avoid calling a wolfSSL helper that is no longer publicly accessible.
Changes:
- Add
WOLFSSL_LIB=1branches across Makefiles to skipWOLFSSL_USER_SETTINGS, link-lwolfssl, and adjust source selection. - Replace direct use of
GetSequenceinwh_server_cert.cwith a local DER sequence helper. - Add a GitHub Actions workflow that builds/installs wolfSSL and compiles multiple targets in
WOLFSSL_LIB=1mode, plus a POSIX smoke test.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/whnvmtool/Makefile | Adds installed-wolfSSL link mode for the whnvmtool build. |
| test/Makefile | Adds installed-wolfSSL link mode for test builds. |
| src/wh_server_cert.c | Replaces a private ASN sequence parser call with a local helper. |
| examples/posix/wh_posix_server/Makefile | Adds installed-wolfSSL link mode for the POSIX server example. |
| examples/posix/wh_posix_client/Makefile | Adds installed-wolfSSL link mode for the POSIX client example. |
| benchmark/Makefile | Adds installed-wolfSSL link mode for benchmark builds. |
| .github/workflows/build-and-test-wolfssl-lib.yml | Adds CI to build and smoke-test the new installed-wolfSSL mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
use local utils function for force zero and compare with SHE set HAVE_ANONYMOUS_INLINE_AGGREGATES=1 with build of wolfSSL in test case rename internal function and adjust test configure add macro guards around bench and crypt test code set LD_LIBRARY_PATH in test case
JacobBarthelmeh
assigned
bigbrett,
wolfSSL-Bot and
billphipps and unassigned
JacobBarthelmeh
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #349
Scan targets checked: wolfhsm-core-bugs, wolfhsm-src
No new issues found in the changed files. ✅
No description provided.