refactored hexToBin function to reduct code paths and increase code c…#241
Open
aidankeefe2022 wants to merge 1 commit into
Open
refactored hexToBin function to reduct code paths and increase code c…#241aidankeefe2022 wants to merge 1 commit into
aidankeefe2022 wants to merge 1 commit into
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #241
Scan targets checked: wolfclu-bugs, wolfclu-src
No new issues found in the changed files. ✅
aidankeefe2022
force-pushed
the
refactor-HexToBin-to-decrease-code-paths
branch
from
0952756 to
26666e9
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #241
Scan targets checked: wolfclu-bugs, wolfclu-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
aidankeefe2022
force-pushed
the
refactor-HexToBin-to-decrease-code-paths
branch
from
26666e9 to
750f158
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #241
Scan targets checked: wolfclu-bugs, wolfclu-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…overage. Previous function had 75% of it never hit causing code branches to not be called this new version removes those and allows for the same logic to be used for all of the function arguments. previous version was also a little harder to read * personal opinion.