removed unused functions and file from wolfCLU. And made minor change…#240
Open
aidankeefe2022 wants to merge 1 commit into
Open
removed unused functions and file from wolfCLU. And made minor change…#240aidankeefe2022 wants to merge 1 commit into
aidankeefe2022 wants to merge 1 commit into
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #240
Scan targets checked: wolfclu-bugs, wolfclu-src
No new issues found in the changed files. ✅
aidankeefe2022
force-pushed
the
removed-dead-code-paths
branch
from
372927a to
1a68608
Compare
… to for loop type to not get compiler error when flag --enable-xmss is turn on for wolfSSL
aidankeefe2022
force-pushed
the
removed-dead-code-paths
branch
from
1a68608 to
7531898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to for loop type to not get compiler error when flag --enable-xmss is turn on for wolfSSL. These functions have zero calls in the entire program and some are possibly in final compiled binary depending on if the compiler feels like optimizing them out. There was also a large function surrounded by #if 0 #endif so that was removed as well.