feat(run_finch): Allow setting conn_max_idle_time via Req interface#542
Open
Slotos wants to merge 1 commit into
Open
feat(run_finch): Allow setting conn_max_idle_time via Req interface#542Slotos wants to merge 1 commit into
conn_max_idle_time via Req interface#542Slotos wants to merge 1 commit into
Conversation
Additionally, this patches a case where presence of `pool_max_idle_time` alone wouldn't trigger custom pool spawn, effectively ignoring the setting. Frankly speaking, this is a quickfix. IMO a proper fix should expose `adapter_options` and, for Finch specifically, validate whether it's a keyword list with no content enforcement. This would eliminate the abstraction leak entirely by narrowing the scope of responsibility. I'm proposing this quickfix as a way to apply fix for AWS Nat Gateway connection termination issue discussed in sneako/finch#272. While `:pool_max_idle_time` can help, it doesn't address the issue as directly as `:conn_max_idle_time` does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, this patches a case where presence of
pool_max_idle_timealone wouldn't trigger custom pool spawn, effectively ignoring the setting.Frankly speaking, this is a quickfix. IMO a proper fix should expose
adapter_optionsand, for Finch specifically, validate whether it's a keyword list with no content enforcement. This would eliminate the abstraction leak entirely by narrowing the scope of responsibility.I'm proposing this quickfix as a way to apply fix for AWS Nat Gateway connection termination issue discussed in
sneako/finch#272. While
:pool_max_idle_timecan help, it doesn't address the issue as directly as:conn_max_idle_timedoes.