Warn and strip userinfo if present in url#540
Open
sabiwara wants to merge 1 commit into
Open
Conversation
Contributor
|
While I agree that Req shouldn't silently ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when an URL with a
userinfolikeReq.get!("https://foo:bar@httpbin.org/basic-auth/foo/bar")is provided,Reqsilently ignores the userinfo, which makes it non-obvious why the request returns a 401:It is especially confusing since
req.urlis still showed with the userinfo, and it can take some time to figure out when migrating an existing project from a library that used to handle the userinfo.This PR adds a warning to shorten the feedback loop and provide actionable steps to address the issue.
We could probably be raising here, I went with a warning to be more conservative and kept the existing behavior - happy to update the strategy if we want to handle it differently.