fix: allow :finch option with IPv6 URLs#538
Merged
Merged
Conversation
wojtekmach
reviewed
Apr 14, 2026
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Req auto-sets
inet6: truewhen the URL host contains:(e.g.http://[::1]:8080/). Thefinch_name/1guard treated:inet6as acustom pool option, causing it to raise "cannot set both :finch and
:connect_options" when a named Finch pool was also provided.
Narrow the guard to only reject
:connect_options, which wouldgenuinely be ignored by a pre-configured Finch instance. The
:inet6flag is orthogonal to pool selection and should not conflict.
This fixes connection pool isolation for services that use separate
named Finch pools when the target is an IPv6 address.