feat(client): custom auth func#520
Draft
james-d-elliott wants to merge 1 commit into
Draft
Conversation
This allows setting a function to provision the smtp.Auth which allows including the tls.ConnState.
Contributor
Author
|
More of a WIP and request for feedback. The idea is being able to use the methods that rely on the tls.ConnectionState with a custom auth method. Needs docs, tests, and some general checks on if I've missed anything (i.e. wbat other legitimate errors could tls.ConnectionState retrieval have?). I'm not sure if there is a way you see this being accomplished other than this that is not breaking, or if you'd prefer to just break it here? |
Owner
|
Thanks for the suggestion James. I'm currently a bit busy, but I'll have a look into this during next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows setting a function to provision the smtp.Auth which allows including the tls.ConnState.