ContextMenu and RightClick done properly.#148
Merged
yoavaa merged 27 commits intowix-incubator:masterfrom Feb 7, 2018
Merged
Conversation
… fit in the normal place (to the right of parent menu item), and adjust popup menu location when we're cramped for space
…tells treecontrol to use it
Open
|
good |
|
When will this pull request be merged? |
Contributor
|
There are too many conflicts to simply merge. Can you help resolve all the conflicts? |
|
Maybe the author @stueynz can help to resolve the conflicts. |
Contributor
Author
|
Gosh it's been a while.... I'll drag it up to master in the coming week. |
Contributor
Author
|
Ok this Pull Request should now be easy for WIX to include in the original project. |
Contributor
|
Hay, just tried to merge. It appears that sortByExpression does not work for some reason. I can see a test failing on that. |
Contributor
|
Merged!!! |
|
Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The context menu functionality from pull request 96 was a little too simplistic. Building context menu from a model was all very well & good, but we needed a few things:
Oh and context-menu-id will work as a directive all on it's own of course.