Skip to content

ci: enable PR duplicate packages check - #17829

Merged
ocavue merged 1 commit into
mainfrom
ocavue/enable-e18e-dupe
Aug 29, 2026
Merged

ocavue merged 1 commit into
mainfrom
ocavue/enable-e18e-dupe

Conversation

@ocavue

@ocavue ocavue commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Changes

We have disabled duplicate-threshold in e18e/action-dependency-diff (by setting it to a large number 100, instead of the default value 1). This PR re-enabled it.

Why we disabled it?

If we enable duplicate-threshold, the previous version of e18e/action-dependency-diff will emit all duplicated packages in the pull request comments. In the astro repo, that’s 200+ packages in total. An example bot comment is shown below:

link:

ocavue-forks#36 (comment)

screenshot:

This information in the comment is too verbose and not useful at all. I guess that's why we disabled it.

Why enable it now?

In the latest e18e/action-dependency-diff v1.7.x, I've contributed a feature that changes duplicate-threshold to only scan the changed dependency in a pull request.

For example, PR #17450 introduced some duplicated package. Now the CI would comment the following content:

link:

ocavue-forks#38 (comment)

screenshot:

The bot comment is much more useful now.

Testing

Green CI

Docs

N/A

@changeset-bot

changeset-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fd2113f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the 🚨 action Modifies GitHub Actions label Aug 26, 2026
@ocavue
ocavue marked this pull request as ready for review August 26, 2026 12:26
@ocavue
ocavue merged commit 7c04f2e into main Aug 29, 2026
24 checks passed
@ocavue
ocavue deleted the ocavue/enable-e18e-dupe branch August 29, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚨 action Modifies GitHub Actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants