Repository navigation
ci: enable PR duplicate packages check - #17829
Merged
Merged
Conversation
|
ocavue
marked this pull request as ready for review
August 26, 2026 12:26
ematipico
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
We have disabled
duplicate-thresholdine18e/action-dependency-diff(by setting it to a large number 100, instead of the default value 1). This PR re-enabled it.Why we disabled it?
If we enable
duplicate-threshold, the previous version ofe18e/action-dependency-diffwill emit all duplicated packages in the pull request comments. In theastrorepo, that’s 200+ packages in total. An example bot comment is shown below:link:
ocavue-forks#36 (comment)
screenshot:
This information in the comment is too verbose and not useful at all. I guess that's why we disabled it.
Why enable it now?
In the latest
e18e/action-dependency-diffv1.7.x, I've contributed a feature that changesduplicate-thresholdto only scan the changed dependency in a pull request.For example, PR #17450 introduced some duplicated package. Now the CI would comment the following content:
link:
ocavue-forks#38 (comment)
screenshot:
The bot comment is much more useful now.
Testing
Green CI
Docs
N/A