test: add allure test steps and removed global clientUserManager singleton pattern(WPB-22314) #4519

emmaoke-w · 2026-01-12T14:02:33Z

WPB-22314 [Android/QA]Refactor tests to include readable step-based reporting with Allure

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Refactored UI tests to introduce explicit Allure test steps that closely reflect real user actions
Remove global ClientUserManager singleton pattern that causes state leakage between tests(Test users (e.g. user1Name) were reused across multiple test classes.
Each test now creates and owns its own instance of ClientUserManager, which is shared only within the scope of that test via TeamHelper.
Tests can now run sequentially
Replaced nullable infrastructure fields with lateinit where they are always initialized in setUp()
Removed unsafe !! null assertions
Restricted test-only fields to private to prevent accidental external access

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Refactored UI tests to introduce explicit Allure test steps that closely reflect real user actions and system boundaries.
Remove global ClientUserManager singleton pattern that causes state leakage between tests(Test users (e.g. user1Name) were reused across multiple test classes.
Each test now creates and owns its own instance of ClientUserManager, which is shared only within the scope of that test via TeamHelper.
Tests can now run sequentially
Replaced nullable infrastructure fields with lateinit where they are always initialized in setUp()
Removed unsafe !! null assertions
Restricted test-only fields to private to prevent accidental external access

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

pull-request-size · 2026-01-12T14:02:41Z

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

yamilmedina

left some comments, looking good

yamilmedina · 2026-01-13T11:35:44Z

tests/testsCore/src/androidTest/kotlin/com/wire/android/tests/core/criticalFlows/FileSharing.kt

    @Suppress("CyclomaticComplexMethod", "LongMethod")
    @TestCaseId("TC-8603")
-    @Category("criticalFlow")
+    @Category("criticalFlow", "testTest")


is this "testTest" needed ?

Thanks for spotting this, I only used the "testTest" for testing

yamilmedina · 2026-01-13T11:36:38Z

...sCore/src/androidTest/kotlin/com/wire/android/tests/core/criticalFlows/NewMemberMessaging.kt

    @Suppress("CyclomaticComplexMethod", "LongMethod")
    @TestCaseId("TC-8605")
-    @Category("criticalFlow")
+    @Category("criticalFlow", "testTest")


Same here, "testTest" does not seem descriptive. maybe leaked into the final PR ?

yamilmedina · 2026-01-13T11:36:55Z

tests/testsCore/src/androidTest/kotlin/com/wire/android/tests/core/pages/RegistrationPage.kt

+//    fun waitUntilLoginFlowIsCompleted(): RegistrationPage {
+//        val device = UiDevice.getInstance(InstrumentationRegistry.getInstrumentation())
+//        waitUntilElementGone(device, loginButtonGoneSelector, timeoutMillis = 12_000)
+//        waitUntilElementGone(device, settingUpWireGoneSelector, timeoutMillis = 35_000)
+//        return this
+//    }
+


Suggested change

// fun waitUntilLoginFlowIsCompleted(): RegistrationPage {

// val device = UiDevice.getInstance(InstrumentationRegistry.getInstrumentation())

// waitUntilElementGone(device, loginButtonGoneSelector, timeoutMillis = 12_000)

// waitUntilElementGone(device, settingUpWireGoneSelector, timeoutMillis = 35_000)

// return this

// }

// fun waitUntilLoginFlowIsCompleted(): RegistrationPage {

// val device = UiDevice.getInstance(InstrumentationRegistry.getInstrumentation())

// waitUntilElementGone(device, loginButtonGoneSelector, timeoutMillis = 12_000)

// waitUntilElementGone(device, settingUpWireGoneSelector, timeoutMillis = 35_000)

// return this

// }

yamilmedina · 2026-01-13T11:40:32Z

tests/testsCore/src/androidTest/kotlin/com/wire/android/tests/core/criticalFlows/FileSharing.kt

+import uiautomatorutils.UiWaitUtils.WaitUtils.waitFor

 @RunWith(AndroidJUnit4::class)
 class FileSharing : BaseUiTest() {


Suggestion/question: I'm wondering if this test class should be renamed to something like: FileSharingBetweenTeams. Since it looks to me it's what we are actually doing in here ?

CinnamonNinja

Looks good to me! Left some minor suggestions.

CinnamonNinja · 2026-01-13T15:43:59Z

...tsCore/src/androidTest/kotlin/com/wire/android/tests/core/criticalFlows/AccountManagement.kt

+                }
+            }
+
+            step("Fetch email verification link from Inbucket") {


Is it good to mention inbucket in open source code? Can we maybe just reduce it to "Fetch email verification link"?

I have removed the inbucket

CinnamonNinja · 2026-01-13T15:46:11Z

.../testsCore/src/androidTest/kotlin/com/wire/android/tests/core/criticalFlows/GroupCallChat.kt

-                    iMinimiseOngoingCall()
-                }
+        }
+        step("Send chat message 'Hello Friends' from user2") {


Does this name need to contain the message and user? Or can it be more generic?

CinnamonNinja · 2026-01-13T15:46:42Z

.../testsCore/src/androidTest/kotlin/com/wire/android/tests/core/criticalFlows/GroupCallChat.kt

-                    false
-                )
+        }
+        step("Share location from user3 and verify call continues") {


also here, do we need to mention the user specifically? Or can it be more generic?

CinnamonNinja · 2026-01-13T15:49:31Z

...src/androidTest/kotlin/com/wire/android/tests/core/criticalFlows/PersonalAccountLifeCycle.kt

-            assertTermsOfUseModalVisible() // Asserts all elements
-            clickContinueButton()
-            // These values are pulled from BuildConfig injected from secrets.json)
+        step("Fetch OTP from Inbucket to complete 2FA verification and complete registration") {


also here, can we remove Inbucket and instead just use "Fetch OTP to complete 2FA verification and complete registration"?

sonarqubecloud · 2026-01-14T16:08:33Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

emmaoke-w added 2 commits January 12, 2026 14:30

add allure test steps and removed singleton pattern

11c16eb

Merge branch 'develop' into test/WPB-22314-add-allure-test-steps

55981d3

pull-request-size bot added the size/XL label Jan 12, 2026

github-actions bot assigned emmaoke-w Jan 12, 2026

github-actions bot added the Fix PR Title 🤦‍♂️ label Jan 12, 2026

emmaoke-w changed the title ~~test: add allure test steps and removed global ClientUserManager singleton pattern (WPB-22314)~~ test: add allure test steps and removed global clientUserManager singleton pattern(WPB-22314) Jan 12, 2026

emmaoke-w requested review from CinnamonNinja and yamilmedina January 12, 2026 14:43

yamilmedina reviewed Jan 13, 2026

View reviewed changes

CinnamonNinja approved these changes Jan 13, 2026

View reviewed changes

yamilmedina and others added 2 commits January 13, 2026 17:59

Merge branch 'develop' into test/WPB-22314-add-allure-test-steps

0e40728

implement pr review suggestions

01244ff

github-actions bot removed the Fix PR Title 🤦‍♂️ label Jan 14, 2026

Merge branch 'develop' into test/WPB-22314-add-allure-test-steps

8a9f7e4

emmaoke-w requested a review from yamilmedina January 14, 2026 16:09

yamilmedina approved these changes Jan 14, 2026

View reviewed changes

emmaoke-w enabled auto-merge January 14, 2026 16:19

emmaoke-w added this pull request to the merge queue Jan 14, 2026

Merged via the queue into develop with commit df76f51 Jan 14, 2026
13 of 14 checks passed

emmaoke-w deleted the test/WPB-22314-add-allure-test-steps branch January 14, 2026 16:37

test: add allure test steps and removed global clientUserManager singleton pattern(WPB-22314) #4519

test: add allure test steps and removed global clientUserManager singleton pattern(WPB-22314) #4519

Uh oh!

Conversation

emmaoke-w commented Jan 12, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Causes (Optional)

Solutions

Dependencies (Optional)

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

Uh oh!

pull-request-size bot commented Jan 12, 2026

Ups 🫰🟨

Uh oh!

yamilmedina left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CinnamonNinja left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 14, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

emmaoke-w commented Jan 12, 2026 •

edited by github-actions bot

Loading