Skip to content

Conversation

@sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Dec 18, 2025

TaskWPB-22343 [Android] Support Collabora feature flag

https://wearezeta.atlassian.net/browse/WPB-22343

What's new in this PR?

Check collabora settings from feature flag to enable / disable feature.

Current logic for enabling the online edit feature for the file:

  • Feature is enabled by client feature flag (to be removed on release)
  • Feature is enabled by configuration from server feature flag
  • Current file format is supported by online editor

@github-actions
Copy link
Contributor

@sbakhtiarov looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
35685adde4487d788ad049ebe6fadc456e091605 d1a950afe78cd7245856597278c9546304e609e3

Is this intentional?

@sbakhtiarov sbakhtiarov force-pushed the feat/cell-config-collabora branch 4 times, most recently from 764195d to 95118e3 Compare January 13, 2026 09:21
@sbakhtiarov sbakhtiarov force-pushed the feat/cell-config-collabora branch from 95118e3 to b964a40 Compare January 13, 2026 09:32
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.72%. Comparing base (aca610c) to head (b964a40).

Files with missing lines Patch % Lines
...getypes/multipart/MultipartAttachmentsViewModel.kt 62.50% 1 Missing and 2 partials ⚠️
...com/wire/android/feature/cells/ui/CellViewModel.kt 66.66% 2 Missing and 1 partial ⚠️
...re/android/feature/cells/ui/CellFileActionsMenu.kt 0.00% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (61.11%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4489      +/-   ##
===========================================
+ Coverage    48.71%   48.72%   +0.01%     
===========================================
  Files          571      571              
  Lines        19673    19685      +12     
  Branches      3293     3295       +2     
===========================================
+ Hits          9583     9591       +8     
- Misses        9082     9083       +1     
- Partials      1008     1011       +3     
Files with missing lines Coverage Δ
...re/android/feature/cells/ui/CellFileActionsMenu.kt 85.18% <0.00%> (-1.86%) ⬇️
...getypes/multipart/MultipartAttachmentsViewModel.kt 53.93% <62.50%> (+2.12%) ⬆️
...com/wire/android/feature/cells/ui/CellViewModel.kt 51.82% <66.66%> (+0.30%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aca610c...b964a40. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbakhtiarov sbakhtiarov added this pull request to the merge queue Jan 13, 2026
Merged via the queue into develop with commit f3ffdb1 Jan 13, 2026
16 of 17 checks passed
@sbakhtiarov sbakhtiarov deleted the feat/cell-config-collabora branch January 13, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants