Skip to content

Conversation

@alexandreferris
Copy link
Member

  • Downgrade Ktor version to 3.2.3 to match SDK's Ktor version

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Github App had Ktor version of 3.3.1 which was higher than the version on the JVM SDK (3.2.3)

Causes (Optional)

As the JVM SDK haven't updated to the latest Ktor version, it fails on cancelled Channels from Ktor

Solutions

Downgrade Ktor version to 3.2.3 to match the JVM SDK version.

* Downgrade Ktor version to 3.2.3 to match SDK's Ktor version
@alexandreferris alexandreferris requested a review from a team as a code owner October 29, 2025 10:52
@alexandreferris alexandreferris self-assigned this Oct 29, 2025
Copy link
Contributor

@spoonman01 spoonman01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an issue even if the app is only using Ktor server and the SDK only using Ktor client? That would be bad for Ktor.
Approve IMHO but we have to figure out if it's our fault that same dependency with 2 versions is not handled, or Ktor fault

@alexandreferris alexandreferris merged commit 488dadc into main Oct 29, 2025
3 checks passed
@alexandreferris alexandreferris deleted the chore/downgrade_ktor_version branch October 29, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants