Skip to content

fix(memory-core): stream embedding cache seed to avoid V8 heap OOM #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesaai merged 1 commit into from
Apr 24, 2026
Merged

fix(memory-core): stream embedding cache seed to avoid V8 heap OOM #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions extensions/memory-core/src/memory/manager-sync-ops.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ export abstract class MemoryManagerSyncOps {
.prepare(
`SELECT provider, model, provider_key, hash, embedding, dims, updated_at FROM ${EMBEDDING_CACHE_TABLE}`,
)
.all() as Array<{
.iterate() as IterableIterator<{
provider: string;
model: string;
provider_key: string;
Expand All @@ -313,9 +313,7 @@ export abstract class MemoryManagerSyncOps {
dims: number | null;
updated_at: number;
}>;
if (!rows.length) {
return;
}
// Note: no early-return on empty iterator; BEGIN/COMMIT over an empty tx is cheap.
const insert = this.db.prepare(
`INSERT INTO ${EMBEDDING_CACHE_TABLE} (provider, model, provider_key, hash, embedding, dims, updated_at)
VALUES (?, ?, ?, ?, ?, ?, ?)
Expand Down
Loading