Support TIDB_VIEWS and TIDB_MLOGS in INFORMATION_SCHEMA#42
Open
xzhangxian1008 wants to merge 12 commits into
Open
Support TIDB_VIEWS and TIDB_MLOGS in INFORMATION_SCHEMA#42xzhangxian1008 wants to merge 12 commits into
xzhangxian1008 wants to merge 12 commits into
Conversation
windtalker
force-pushed
the
mv_test
branch
3 times, most recently
from
aba8bed to
ee7c8a2
Compare
xzhangxian1008
changed the title
windtalker
reviewed
May 28, 2026
| err error | ||
| ) | ||
| switch { | ||
| case (!hasMLogPredicates && !hasBasePredicates) || (hasMLogPredicates && !hasBasePredicates): |
Owner
There was a problem hiding this comment.
it seems the case can be simplified to case !hasBasePredicates, is it the expected behavior?
| ) | ||
| switch { | ||
| case (!hasMLogPredicates && !hasBasePredicates) || (hasMLogPredicates && !hasBasePredicates): | ||
| schemas, tables, err = ex.ListSchemasAndTables(ctx, e.is) |
Owner
There was a problem hiding this comment.
maybe construct the baseInfos here, so there is no need to check it in L1739
| // NewInfoSchemaTiDBMLogsExtractor creates a new InfoSchemaTiDBMLogsExtractor. | ||
| func NewInfoSchemaTiDBMLogsExtractor() *InfoSchemaTiDBMLogsExtractor { | ||
| e := &InfoSchemaTiDBMLogsExtractor{} | ||
| e.extractableColumns = extractableCols{ |
Owner
There was a problem hiding this comment.
why extractableColumns and colNames is not the same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.