Repository navigation
feat: hide items from home's recently run panel - #12572
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… counts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying windmill with
|
| Latest commit: |
afc6bc2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f2c49825.windmill.pages.dev |
| Branch Preview URL: | https://handle-run-hide-items-dropdo.windmill.pages.dev |
|
Claude finished @rubenfiszel's task in 1m 3s —— View job cc @Guilhem-lm Mergeable, but should ideally address nits: hidden items not moved on email rename or cleared on user removal, path longer than 255 chars on
SummaryThe design holds up. Hidden runs are dropped before counting, so items past the Findings
AGENTS.md compliance
Test coverage
Manual verification still needed: the unchecked item in the test plan. Hide one script, one flow and one agent from the side panel's row menu. Each should leave the list, and its failures should leave both the panel's counts and the header status badge. Unhide each from the header status popover: the popover should stay open and the row and its counts should come back. Also, with only hidden items in the window, the panel should show the "N hidden items" section and not the "Runs show up here once something runs." message. |
| -- list and counts for that user only. | ||
| CREATE TABLE recent_run_hidden_item ( | ||
| workspace_id VARCHAR(50) NOT NULL REFERENCES workspace(id) ON DELETE CASCADE, | ||
| email VARCHAR(255) NOT NULL, |
There was a problem hiding this comment.
P2: these rows are keyed by email, but nothing updates them when a user's email changes. The instance-level email rename in backend/windmill-api-users/src/users.rs (around lines 1965–2122, plus draft/draft_move in windmill-common/src/user_drafts.rs) moves every per-email table (tutorial_progress, token, schedule, capture_config, draft, …). After a rename the user's hidden items silently come back, and the old-email rows stay behind as orphans. Something like UPDATE recent_run_hidden_item SET email = $1 WHERE email = $2 next to tutorial_progress would fix it.
Same gap on removal: the workspace user delete clears favorite (users.rs:2633) but not these rows, so a user who is removed and later re-added gets their old hidden list back.
Codex ReviewGood to merge No introduced bugs, security issues, or clear AGENTS.md violations found. Test coverageNo Rust unit or integration tests were added for hide/unhide, count filtering, or workspace rename. The PR documents manual API and UI checks. Frontend changes add component and state wiring; component tests are not expected. This was a static review; I did not run tests or exercise the application. The remaining manual check is to hide and restore a script, flow, and agent, confirming their runs leave and reenter the panel and header counts. |
Pi Reviewcc @Guilhem-lm Mergeable, but should ideally address nits: hidden items without a summary don't show their path; no automated test for hide/unhide and hidden-counting. The feature is well scoped: the migration keys rows per P2 —
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex ReviewGood to merge No confident introduced bugs, security issues, or clear AGENTS.md violations found. The latest commit addresses the earlier cleanup, path-length, and hidden-path display findings. Test coverageNo Rust unit or integration tests were added for hide/unhide, hidden-run counting, or lifecycle cleanup. Existing recent-run tests cover tag scoping and resolved failures. Frontend changes are component and state wiring; component tests are not expected. The PR reports manual API, UI, and workspace-rename checks. I performed static review and ran Complete the open checklist by hiding and unhiding a script, flow, and agent, confirming their runs leave and return to both panel and header counts. Also exercise the latest lifecycle changes: hidden items should survive an email rename and clear after workspace-user removal and re-addition. |
Pi Reviewcc @Guilhem-lm Mergeable, but should ideally address nits: no automated test for hide/unhide and the hidden-count exclusion. The three prior findings are all correctly addressed. Verifying each fix:
No new blockers are introduced by these commits. P2 — no automated test for hide/unhide and the hidden-count exclusion (
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Each row of Home's Recently run panel gets a menu with Hide item from Recently run. Hidden items are kept per user and per workspace on the server. Their runs are left out of the panel's list and of every count, so the panel and the header status agree. Below the list, a collapsible "N hidden items" section lists them, with Unhide on each and Unhide all.
Changes
recent_run_hidden_item(workspace_id, email, kind, path, hidden_at), keyed per user and item, cascading on workspace delete. Admin-only RLS policy as a backstop; the handlers use the raw pool scoped to the caller's own rows.GET /w/{workspace}/jobs/recent_runsdrops the caller's hidden items from the runs before counting, sototal_runs,failed_runs,failing_itemsandrunning_itemsexclude them even when an item falls past the 50-item cut. It returns them in a newhidden_itemsfield (within thefolderfilter, with summaries), including items with no run in the window.POST /w/{workspace}/jobs/recent_runs/hideand/unhidetake{items: [{kind, path}]}; an unknown kind returns 400.favorite.DropdownV2row menu in the side panel (not in the header status popover, where a dropdown would close it), andRecentRunsHiddenHint, the collapsible hidden list in both the panel and the header status popover. Hiding or unhiding rereads the panel (about 100 ms locally). The cached read's version is bumped for the new field.Screenshots
Before: the panel has no row menu.
Row menu:
Two items hidden, section collapsed (the failed count no longer includes Daily ETL pipeline):
Section expanded, with per-item Unhide and Unhide all:
Header status popover with the panel closed:
Test plan
Checked on a local backend with a seeded copy of the dev database:
f/data/daily_etl_pipelineinacmetakestotal_runsfrom 125 to 124 andfailed_runsfrom 2 to 1, and removes the item;hidden_itemsreturns it with its summary, plus a hidden item with no runs;?folder=billinglists none of them; kindappreturns 400; unhide restores everything.🤖 Generated with Claude Code