Repository navigation
fix: respect minimal telemetry on manual stats send and download - #12570
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
/review |
|
Claude finished @hugocasa's task in 40s —— View job Good to merge Review
What changed: Matches the scheduled path: On EE (
CE: the OSS Companion EE change: the FindingsNone. AGENTS.md complianceNo violations. The change is small, adds no comments that just narrate the code, and the EE ref bump follows Test coverageBackend: only two call-site arguments changed, and the payload builder underneath was already in place. A unit test wouldn't protect anything meaningful, so none is expected. Manual verification: the PR's own test plan already covers |
Pi ReviewGood to merge The change is a small, correct fix: the superadmin Send usage ( I verified:
Considered and dismissed
Test coverage Backend change, but the public-repo diff is a three-line plumbing fix (passing an existing helper's result as a flag); the gating logic itself lives in the EE companion. No automated tests were added in the public repo, which is reasonable for a flag pass-through, and there are no integration tests exercising the manual send/download handlers here — worth noting, though the change is too thin to meaningfully unit test on its own. Manual verification is still needed for the Send usage action, which the PR author already flagged as unobserved on the wire: with |
Codex ReviewGood to merge No issues found. Test coverageNo automated regression tests were added. The PR reports EE download verification with minimal telemetry enabled and disabled. I did not run tests or exercise a live instance. I inspected the pinned EE source; the previous EE ref was unavailable locally for comparison. Manual Send usage verification remains: capture requests with a local telemetry stub under both saved settings and confirm detailed sections, including |
This commit updates the EE repository reference after PR #1001 was merged in windmill-ee-private. Previous ee-repo-ref: aa41f4277be8f39dc71cbb044f817da0fcb82a4f New ee-repo-ref: d01848c5a62d19896cf5c67dd0b69582e5365be9 Automated by sync-ee-ref workflow.
|
🤖 Updated |
|
I'll analyze this and get back to you. |

Summary
With minimal telemetry on (the
disable_statssetting in EE), the scheduled send drops the detailed sections, but the superadmin Send usage and Download usage actions always built the full payload (minimal = false). Git sync usage was also never gated onminimal, so even the scheduled minimal payload carried it.Changes
windmill-api-settings:send_statsandget_statspass thedisable_statssetting asminimal, the same value the scheduled send uses. Both read the saved setting, so a toggle change has to be saved before it applies.stats_ee.rs, companion PR windmill-labs/windmill-ee-private):git_sync_usageis omitted whenminimalis true, likefeature_usage,instance_onboarding,resource_usageandinfra_info.ee-repo-ref.txtbumped to the companion commit.Test plan
enterprise,private), one git sync repo configured,GET /api/settings/get_stats:disable_stats=false:git_sync_usage {sync_repos: 1}, onboarding, resource usage and infra info presentdisable_stats=true: all four are absentdev_overrideto point at a local stats stub); it calls the same payload builder with the same flag.🤖 Generated with Claude Code
Summary by cubic
Fixes manual telemetry actions so they respect the minimal telemetry setting, matching the scheduled send behavior.
Previously, the superadmin Send usage and Download usage actions always built the full stats payload even when
disable_statswas enabled, and git sync usage was included in scheduled minimal payloads too. Now both manual actions read the saveddisable_statssetting and pass it as theminimalflag, and git sync usage is omitted from minimal payloads in the EE code.Written for commit e5438aa. Summary will update on new commits.