Repository navigation
chore: bump the ts and csharp wasm parsers to 1.880.1 - #12565
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
/review |
|
Claude finished @rubenfiszel's task in 31s —— View job Good to merge Review
What changed: four files, each bumping the same two pins: API compatibility: I checked the functions the code imports against the
All of them are still exported with the same signatures. The Findings: none. AGENTS.md: this PR only changes dependency versions. No rule about code, comments, migrations or generated files applies. Test coverageThis PR only touches dependencies and config, so no new automated tests are expected. The behaviour it brings in (#12515's JSDoc The PR description already covers the manual checks:
One more check would be worth doing: open an existing Bun or Deno script that has no JSDoc and confirm its inferred schema is unchanged. Nothing else is needed before merge. |
Pi ReviewGood to merge A clean, well-scoped dependency bump. The diff touches exactly four files — What I verified
Considered and dismissed
Test coverageCI / workflows / config-only change — no automated tests expected, and none are warranted for a two-line version pin per manifest. The parser behavior itself (#12515 JSDoc The PR description's manual checks are adequate: the editor run form showing JSDoc descriptions, and |
Deploying windmill with
|
| Latest commit: |
68359bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://572402e6.windmill.pages.dev |
| Branch Preview URL: | https://rf-bump-ts-csharp-parsers.windmill.pages.dev |
Codex ReviewGood to merge No issues found. Both manifests and lockfiles consistently pin the two parsers to 1.880.1. Downloaded npm tarballs match both lockfiles’ integrity hashes, contain the expected WASM assets, and retain the exports their consumers use. Test coverageNo new automated tests are expected for this dependency-only change. I initialized both published WASM packages in Node and exercised TS JSDoc descriptions, C# defaults, and TS import/output parsing. The author reports successful clean installs, editor verification, and CLI metadata generation; I did not rerun those end to end. Remaining manual smoke check: open an existing Bun/Deno script without JSDoc and confirm its inferred run-form schema remains unchanged. |
|
I'll analyze this and get back to you. |

Summary
Pins the newly published
windmill-parser-wasm-tsandwindmill-parser-wasm-csharp1.880.1 in the frontend and the CLI, so two merged parser changes reach users:@paramfills an empty argument description, in the editor and inwmill generate-metadata.Both packages were built from main at 1.880.1 and published to npm.
Changes
frontend/package.jsonandfrontend/package-lock.json:windmill-parser-wasm-ts1.695.0 → 1.880.1,windmill-parser-wasm-csharp1.510.1 → 1.880.1. The lockfile changes only those two entries (version, tarball URL and the integrity npm serves).cli/package.jsonandcli/bun.lock: the same two bumps.Test plan
npm ciinfrontend/installs 1.880.1 from the lockfile, andbun install --frozen-lockfiledoes the same incli/.@param name Who to greetand@param {number} times - How many timesshows both descriptions in the run form (screenshot below).wmill generate-metadatafrom this branch's CLI:description: Who to greetanddescription: How many times;Main(int a, int b = 3)getsbwith default 3 and onlyarequired.Screenshots
The editor with the new TS parser: the JSDoc
@paramtext shows as each argument's description.🤖 Generated with Claude Code
Summary by cubic
Bumps
windmill-parser-wasm-tsandwindmill-parser-wasm-csharpto 1.880.1 in the frontend and CLI so two parser fixes reach users.@paramnow fills an empty argument description in the editor and inwmill generate-metadata.Written for commit 68359bc. Summary will update on new commits.