Skip to content

chore: bump the ts and csharp wasm parsers to 1.880.1 - #12565

Merged
rubenfiszel merged 1 commit into
mainfrom
rf/bump-ts-csharp-parsers
Nov 20, 2026
Merged

rubenfiszel merged 1 commit into
mainfrom
rf/bump-ts-csharp-parsers

Conversation

@rubenfiszel

@rubenfiszel rubenfiszel commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Pins the newly published windmill-parser-wasm-ts and windmill-parser-wasm-csharp 1.880.1 in the frontend and the CLI, so two merged parser changes reach users:

Both packages were built from main at 1.880.1 and published to npm.

Changes

  • frontend/package.json and frontend/package-lock.json: windmill-parser-wasm-ts 1.695.0 → 1.880.1, windmill-parser-wasm-csharp 1.510.1 → 1.880.1. The lockfile changes only those two entries (version, tarball URL and the integrity npm serves).
  • cli/package.json and cli/bun.lock: the same two bumps.

Test plan

  • npm ci in frontend/ installs 1.880.1 from the lockfile, and bun install --frozen-lockfile does the same in cli/.
  • Script editor, frontend from this branch against a local backend: a Bun script with @param name Who to greet and @param {number} times - How many times shows both descriptions in the run form (screenshot below).
  • wmill generate-metadata from this branch's CLI:
    • the same TS script gets description: Who to greet and description: How many times;
    • a C# Main(int a, int b = 3) gets b with default 3 and only a required.

Screenshots

The editor with the new TS parser: the JSDoc @param text shows as each argument's description.

editor-jsdoc-descriptions

🤖 Generated with Claude Code


Summary by cubic

Bumps windmill-parser-wasm-ts and windmill-parser-wasm-csharp to 1.880.1 in the frontend and CLI so two parser fixes reach users.

  • A TypeScript JSDoc @param now fills an empty argument description in the editor and in wmill generate-metadata.
  • A C# parameter with a default value is now treated as optional.

Written for commit 68359bc. Summary will update on new commits.

View guided diff Turn on auto-fix

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rubenfiszel

Copy link
Copy Markdown
Contributor Author

/review

@claude

claude Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @rubenfiszel's task in 31s —— View job


Good to merge

Review

  • Read the diff (git diff origin/main...HEAD)
  • Checked that the manifests and lockfiles agree
  • Checked that the exports the frontend and CLI import still exist

What changed: four files, each bumping the same two pins: windmill-parser-wasm-ts from 1.695.0 to 1.880.1 and windmill-parser-wasm-csharp from 1.510.1 to 1.880.1. The frontend/package-lock.json entries (version, tarball URL, integrity) match frontend/package.json. The cli/bun.lock workspace entries and package hashes match cli/package.json. Each package has the same integrity hash in both lockfiles, so the frontend and the CLI resolve the same tarball. No other dependency moved.

API compatibility: I checked the functions the code imports against the #[wasm_bindgen] exports in backend/parsers/windmill-parser-wasm/src/ on main, which is what 1.880.1 was built from:

  • frontend/src/lib/infer.ts imports parse_deno, parse_outputs and parse_csharp.
  • frontend/src/lib/relative_imports.ts imports parse_ts_imports.
  • cli/src/utils/relative_imports.ts imports parse_ts_relative_imports(code, path).
  • cli/src/utils/metadata.ts imports parse_deno and parse_csharp.

All of them are still exported with the same signatures. The windmill_parser_wasm_bg.wasm?url import path in infer.ts follows the package's standard wasm-pack layout. I did not install the packages, so I did not confirm that file inside the 1.880.1 tarball. The test plan's npm ci and the working editor cover it.

Findings: none.

AGENTS.md: this PR only changes dependency versions. No rule about code, comments, migrations or generated files applies.

Test coverage

This PR only touches dependencies and config, so no new automated tests are expected. The behaviour it brings in (#12515's JSDoc @param descriptions and #10185's optional C# parameters with defaults) belongs to the parser crate and was reviewed in those PRs.

The PR description already covers the manual checks:

  • the editor's run form shows the JSDoc descriptions;
  • wmill generate-metadata writes the TS descriptions, and gives the C# b = 3 parameter default 3 with only a required.

One more check would be worth doing: open an existing Bun or Deno script that has no JSDoc and confirm its inferred schema is unchanged. Nothing else is needed before merge.

@github-actions

Copy link
Copy Markdown
Contributor

Pi Review

Good to merge

A clean, well-scoped dependency bump. The diff touches exactly four files — frontend/package.json, frontend/package-lock.json, cli/package.json, cli/bun.lock — and only the two parser pins move: windmill-parser-wasm-ts 1.695.0 → 1.880.1 and windmill-parser-wasm-csharp 1.510.1 → 1.880.1 (16 insertions / 16 deletions total, nothing else moved).

What I verified

  • Manifest/lockfile agreement. Both lockfiles resolve the same versions their manifests pin, and only the expected entries changed. frontend/package-lock.json updates version, tarball URL, and integrity for each package; cli/bun.lock updates the workspace dependency lines plus the two hashes.
  • Cross-lockfile consistency. The integrity hashes agree between npm and bun:
    • windmill-parser-wasm-csharp@1.880.1: sha512-F95aWVcFKbT8APvBYXIp8UcndYU97Jth+SFsyHJOkR4TdqEWBXebYEwS10gYqehSDtcZBON11A39Kwn+D9WCZg== in both.
    • windmill-parser-wasm-ts@1.880.1: sha512-I+rcl+E8k1KnHHNG0plTWeYh6BMhn+WD9JsRlgxbuqiKCn//KESUjEOYCWhpvf7pNQhJaYC1QoXNYRUu03rNkQ== in both.
      So the frontend and the CLI resolve byte-identical tarballs.
  • API compatibility. Every import the two consumers make still exists with the same signature in backend/parsers/windmill-parser-wasm/src/lib.rs on main, which is what 1.880.1 was built from: parse_deno(code, main_override) and parse_outputs(code) (frontend/src/lib/infer.ts, cli/src/utils/metadata.ts), parse_ts_imports(code) (frontend/src/lib/relative_imports.ts), parse_ts_relative_imports(code, path) (cli/src/utils/relative_imports.ts), and parse_csharp(code) (frontend/src/lib/infer.ts, cli/src/utils/metadata.ts). The windmill_parser_wasm_bg.wasm?url import path in infer.ts follows the standard wasm-pack layout.

Considered and dismissed

  • Large version jump (1.695.0 → 1.880.1, 1.510.1 → 1.880.1). These are Windmill's own parser wasm packages built from main, not semver-significant releases from an external maintainer; the version is the package's internal build number. The PR states both were built from main at 1.880.1 and published to npm. No defect.
  • "Built from main" could carry unrelated parser changes beyond feat: fill argument descriptions from JSDoc @param and Python Args: #12515 and fix(csharp-parser): mark parameters with a default value as optional #10185. This is the standard workflow for these packages (they only exist as published artifacts built from main), and the two behavior changes named in the body are the only ones the PR claims to deliver. Not a finding.
  • Lockfile tarball/integrity I cannot confirm against npm without network. The author's test plan explicitly ran npm ci and bun install --frozen-lockfile, and the working editor screenshot exercises the actual loaded wasm. The integrity hashes match across both lockfiles, which is the cross-check available in-repo.
  • ?url import path could break if the tarball layout changed. wasm-pack output layout (windmill_parser_wasm_bg.wasm at package root) is stable across versions and unchanged by this bump.

Test coverage

CI / workflows / config-only change — no automated tests expected, and none are warranted for a two-line version pin per manifest. The parser behavior itself (#12515 JSDoc @param descriptions, #10185 optional C# default parameters) belongs to the parser crates and was covered in those PRs.

The PR description's manual checks are adequate: the editor run form showing JSDoc descriptions, and wmill generate-metadata emitting TS descriptions plus the C# b = 3 default with only a required. One additional smoke test is worth doing before merge — open an existing Bun/Deno script with no JSDoc and confirm its inferred schema is unchanged, to rule out any regression in the default parse path.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 68359bc
Status: ✅  Deploy successful!
Preview URL: https://572402e6.windmill.pages.dev
Branch Preview URL: https://rf-bump-ts-csharp-parsers.windmill.pages.dev

View logs

@github-actions

Copy link
Copy Markdown
Contributor

Codex Review

Good to merge

No issues found. Both manifests and lockfiles consistently pin the two parsers to 1.880.1. Downloaded npm tarballs match both lockfiles’ integrity hashes, contain the expected WASM assets, and retain the exports their consumers use.

Test coverage

No new automated tests are expected for this dependency-only change. I initialized both published WASM packages in Node and exercised TS JSDoc descriptions, C# defaults, and TS import/output parsing. git diff --check passed.

The author reports successful clean installs, editor verification, and CLI metadata generation; I did not rerun those end to end. Remaining manual smoke check: open an existing Bun/Deno script without JSDoc and confirm its inferred run-form schema remains unchanged.

@rubenfiszel
rubenfiszel marked this pull request as ready for review November 20, 2026 12:46
@rubenfiszel
rubenfiszel merged commit 67b1f15 into main Nov 20, 2026
22 of 24 checks passed
@rubenfiszel
rubenfiszel deleted the rf/bump-ts-csharp-parsers branch November 20, 2026 12:46
@claude

claude Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Claude Code is working…

I'll analyze this and get back to you.

View job run

@github-actions github-actions Bot locked and limited conversation to collaborators Nov 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant