Skip to content

chore(main): release 1.880.0 - #12548

Merged
rubenfiszel merged 2 commits into
mainfrom
release-please--branches--main--components--windmill
Nov 19, 2026
Merged

rubenfiszel merged 2 commits into
mainfrom
release-please--branches--main--components--windmill

Conversation

@rubenfiszel

@rubenfiszel rubenfiszel commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

🤖 I have created a release beep boop

1.880.0 (2026-11-19)

Features

  • record and download a worker group's autoscaling decisions (#12542) (5583c68)

Bug Fixes

  • api: noindex public app pages on cloud (#12547) (cbf44b3)
  • hold the configured AI key to its output token limits (#12543) (6c2c5cf)
  • keep the AI sessions view mounted across navigation (#12479) (7fa093f)
  • name a step inside a subflow sub:inner in flow tests (#12549) (50daf70)

This PR was generated with Release Please. See documentation.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9209d4f
Status:⚡️  Build in progress...

View logs

@claude

claude Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @rubenfiszel's task in 16s —— View job


Good to merge

Summary

This is a Release Please PR that moves the version from 1.879.0 to 1.879.1. It touches three files:

Findings

None. All three files agree on 1.879.1. The changelog entry matches the one commit between v1.879.0 and this release (7fa093f), and its compare link points to v1.879.0...v1.879.1. A patch bump is the right size for a release whose only change is a fix:.

AGENTS.md compliance

Nothing applies here: the PR changes no code, only generated release metadata.

Test coverage

None is expected, since the PR only changes release and version config. No manual check is needed before merge, because nothing in the app changes.

@github-actions

Copy link
Copy Markdown
Contributor

Pi Review

Good to merge

This is a standard Release Please patch release bumping 1.879.0 → 1.879.1. All three touched files agree on the new version, the changelog entry correctly attributes the single bug fix (7fa093f) that landed between the two tags, and the compare link targets v1.879.0...v1.879.1. No code, API, frontend, or config behavior changes.

Considered and dismissed

  • Version inconsistency across files — dismissed: .release-please-manifest.json, version.txt, and the new CHANGELOG.md section all state 1.879.1; git log confirms the only commit in the range is the release commit itself.
  • Changelog references the wrong commit — dismissed: the entry cites 7fa093f ("keep the AI sessions view mounted across navigation"), which is the base SHA and the sole fix between the two tags.
  • Wrong bump size — dismissed: the only change is a fix:, so a patch bump (1.879.1) is correct rather than minor/major.
  • Malformed compare link — dismissed: v1.879.0...v1.879.1 matches the adjacent 1.879.0 section's own range (v1.878.0...v1.879.0), and the changelog format is consistent with the surrounding entries.

AGENTS.md compliance

Nothing applies: the PR changes only generated release metadata, no code or docs.

Test coverage

CI / workflows / docs / config-only — no automated tests expected.

No manual verification is needed before merge: there is no in-app surface to exercise; the diff is purely release versioning and changelog metadata.

@github-actions

Copy link
Copy Markdown
Contributor

Pi Review

Good to merge

This is a standard Release Please patch release bumping 1.879.0 → 1.879.1. All 22 touched files agree on the new version, the changelog entry correctly attributes the single bug fix that landed between the two tags, and the compare link targets the right range. No code, API, frontend, or config behavior changes.

Considered and dismissed

  • Version inconsistency across files — dismissed: .release-please-manifest.json, version.txt, backend/Cargo.toml, both Cargo.lock files, all package.json/package-lock.json pairs, openapi.yaml, openflow.openapi.yaml, benchmarks/lib.ts, cli/src/core/constants.ts, lsp/Pipfile, powershell-client/WindmillClient.psd1, python-client/wmill/pyproject.toml, and the TypeScript client all state 1.879.1.
  • Changelog references the wrong commit — dismissed: the entry cites 7fa093f ("keep the AI sessions view mounted across navigation"), which is the base SHA and the sole fix: between the two tags; git log confirms the only commits in the range are the release commit and its follow-up.
  • Wrong bump size — dismissed: the only change is a fix:, so a patch bump (1.879.1) is correct rather than minor/major.
  • Malformed compare link — dismissed: v1.879.0...v1.879.1 matches the adjacent section's range pattern and the changelog format is consistent with surrounding entries.
  • Extra "Apply automatic changes" commit in the range — dismissed: it is release-please's standard follow-up and the combined diff touches only version metadata, nothing else.
  • Files missed by the bump — dismissed: the set of bumped files is driven by the release-please configuration and the manifest, and every version-bearing file in the repo is updated consistently.

AGENTS.md compliance

Nothing applies: the PR changes only generated release metadata, no code or docs.

Test coverage

CI / workflows / docs / config-only — no automated tests expected.

No manual verification is needed before merge: there is no in-app surface to exercise; the diff is purely release versioning and changelog metadata.

@github-actions

Copy link
Copy Markdown
Contributor

Codex Review

Good to merge

No issues found. The 22-file diff consistently updates release metadata to 1.879.1, and the changelog matches the cited fix.

Test coverage

No automated tests are expected for this metadata-only change. Read-only checks confirmed exact version substitutions, valid changed JSON/TOML files, and a clean git diff --check.

There is no in-app surface to exercise; no manual verification is needed.

@rubenfiszel
rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from fef3665 to 6c2c90b Compare November 19, 2026 16:41
@github-actions

Copy link
Copy Markdown
Contributor

Pi Review

Good to merge

This is a standard Release Please patch release bumping 1.879.0 → 1.879.1. The diff touches only the three generated release files, all of which agree on the new version, and the changelog correctly captures every fix commit since v1.879.0.

Verified against history: 87c9d0d is the chore(main): release 1.879.0 commit, and exactly two commits sit between it and this PR's head — 7fa093f (#12479, AI sessions view) and cbf44b3 (#12547, noindex public app pages). Both are listed in the new changelog section, and the compare link v1.879.0...v1.879.1 matches that range.

Considered and dismissed

  • Version inconsistency across files — dismissed: .release-please-manifest.json (".": "1.879.1"), version.txt (1.879.1), and the new CHANGELOG.md heading all state 1.879.1. No other files are touched in this diff.
  • Changelog lists a commit already in the prior release — dismissed: cbf44b3 is the PR's base SHA, not the v1.879.0 tag. git log shows cbf44b3 (and its parent 7fa093f) both land after 87c9d0d (release 1.879.0), so both belong in the 1.879.1 section.
  • Wrong bump size — dismissed: the only changes since v1.879.0 are two fix: commits, so a patch bump (1.879.1) is correct.
  • Changelog ordering — dismissed: cbf44b3 (noindex) listed before 7fa093f (AI sessions) is reverse-chronological (newest commit first), which is the standard Release Please ordering; not an issue.
  • Malformed compare link — dismissed: v1.879.0...v1.879.1 follows the exact pattern of the adjacent section, which is consistent with the rest of the file.

AGENTS.md compliance

Nothing applies: the PR changes only generated release metadata (CHANGELOG.md, version manifest, version.txt), no code, docs, or public surface.

Test coverage

CI / workflows / docs / config-only — no automated tests expected.

No manual verification is needed before merge: there is no in-app surface to exercise; the diff is purely release versioning and changelog metadata.

@github-actions

Copy link
Copy Markdown
Contributor

Codex Review

Good to merge

No issues found in the exact three-file diff. Release metadata consistently specifies 1.879.1, and both changelog entries match their cited commits.

Test coverage

No automated tests are expected for this metadata-only change. Read-only checks covered the exact commit range and diff, manifest JSON parsing, version consistency, cited commit subjects, and git diff --check; all passed. The previous-release tag was unavailable locally, so its full commit range was not verified.

There is no in-app surface to exercise; no manual verification is needed before merge.

@github-actions

Copy link
Copy Markdown
Contributor

Pi Review

Good to merge

This is a standard Release Please patch release bumping 1.879.0 → 1.879.1. The 22-file diff touches only generated release metadata, every version-bearing file agrees on 1.879.1, and the changelog correctly captures the two fix: commits that landed between v1.879.0 and this head.

Verified against history: 87c9d0d is chore(main): release 1.879.0, and exactly two fix commits follow it — 7fa093f (#12479, AI sessions view) and cbf44b3 (#12547, noindex public app pages). Both appear in the new changelog section with correct SHAs and issue links, and the compare link v1.879.0...v1.879.1 matches that range.

Considered and dismissed

  • Version inconsistency across files — dismissed: .release-please-manifest.json, version.txt, backend/Cargo.toml (package + workspace), both Cargo.lock files (all windmill-* package entries), both package.json/package-lock.json pairs, openapi.yaml, openflow.openapi.yaml, benchmarks/lib.ts, cli/src/core/constants.ts (both VERSION constants, including the v-prefixed one), lsp/Pipfile, powershell-client/WindmillClient.psd1, python-client/wmill/pyproject.toml, and the TypeScript client all move 1.879.0 → 1.879.1 uniformly.
  • Changelog lists a commit already released — dismissed: cbf44b3 is the PR's base SHA, not the v1.879.0 tag. It and 7fa093f both land after 87c9d0d (release 1.879.0), so both belong in the 1.879.1 section.
  • Wrong bump size — dismissed: the only changes since v1.879.0 are two fix: commits, so a patch bump is correct.
  • Non-version content smuggled into the diff — dismissed: filtering the full diff for any added/removed line that is not a 1.879.0/1.879.1 substitution yields only the changelog block; Cargo.lock contains no dependency additions/removals, only windmill-* version field bumps.
  • Malformed compare link — dismissed: v1.879.0...v1.879.1 follows the exact pattern of the adjacent 1.879.0 section (v1.878.0...v1.879.0).

AGENTS.md compliance

Nothing applies: the PR changes only generated release metadata (CHANGELOG.md, version manifest, version.txt, and the derived version strings in build/config files), no code, docs, or public surface.

Test coverage

CI / workflows / docs / config-only — no automated tests expected.

No manual verification is needed before merge: there is no in-app surface to exercise; the diff is purely release versioning and changelog metadata.

@github-actions

Copy link
Copy Markdown
Contributor

Codex Review

Good to merge

No issues found. The exact 22-file diff consistently updates release metadata to 1.879.1, and both changelog entries match their cited commits.

Test coverage

No automated tests are expected for this metadata-only change. Read-only checks confirmed exact version substitutions, valid changed JSON/TOML documents, and a clean git diff --check.

There is no in-app surface to exercise; no manual verification is needed.

@rubenfiszel
rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 9b20044 to 891d0b4 Compare November 19, 2026 16:51
@github-actions

Copy link
Copy Markdown
Contributor

Codex Review

Good to merge

No issues found. Release versions and all three changelog entries are consistent. The three dependency upgrades have consistent lockfile references.

Test coverage

No new tests are expected for the release metadata. Read-only checks passed for version substitutions, JSON/TOML parsing, lockfile consistency, cited commits, and git diff --check. Compilation and runtime tests were not run; existing backend CI should cover the dependency upgrades.

There is no new in-app surface to exercise; no manual verification is needed.

@github-actions

Copy link
Copy Markdown
Contributor

Pi Review

cc @rubenfiszel

Mergeable, but should ideally address nits: unannounced transitive dependency upgrades in backend/Cargo.lock; fix: commit #12546 absent from CHANGELOG.md.

Findings

P2 — backend/Cargo.lock ships three transitive dependency upgrades that the changelog does not mention and main-branch CI never tested

The release's "Apply automatic changes" commit runs cargo generate-lockfile (.github/workflows/change-versions.yml, update lockfile step), which re-resolves the entire dependency graph, not just the windmill-* version fields. In this release that upgraded, beyond the 1.879.0 → 1.879.1 version bumps:

  • pin-project 1.1.13 → 1.2.0 (backend/Cargo.lock:9832-9833)
  • pin-project-internal 1.1.13 → 1.2.0 (:9841-9842), whose syn dependency changes 2.0.119 → 3.0.10 (:9847)
  • pin-project-lite 0.2.17 → 0.2.18 (:9852-9853)

These are real dependency changes, not version-string substitutions — the previous 1.879.0 release's Cargo.lock diff contained only windmill-* version bumps. The practical effect is that the tagged v1.879.1 binaries are built against pin-project 1.2.0 / pin-project-lite 0.2.18, which no commit in the 1.879.1 range was tested against, and none of it appears in the changelog. Low risk in practice (semver-compatible bumps), but worth reviewing the cargo generate-lockfile step or the resulting lockfile diff before tagging, so a patch release doesn't silently carry dependency changes.

P2 — CHANGELOG.md:4-10 omits the fix: commit "keep the python client generator within memory" (#12546)

The range v1.879.0..<release base> (87c9d0d..4472b5b9) contains four commits, three of which are fix: commits and are listed correctly. The fourth, 4472b5b94 (#12546), is also a fix: in substance ("keep the python client generator within memory" — a memory-perf fix), but its PR title/commit subject lacks a conventional-commit prefix, so Release Please ("simple" release type) drops it from the changelog. Minor completeness gap; the release itself is correct, just under-documented.

Considered and dismissed

  • Version inconsistency across the 22 touched files — dismissed: .release-please-manifest.json, version.txt, backend/Cargo.toml (workspace + package), all windmill-* entries in both Cargo.locks, every package.json/package-lock.json, openapi.yaml, openflow.openapi.yaml, benchmarks/lib.ts, cli/src/core/constants.ts, lsp/Pipfile, the PowerShell manifest, pyproject.toml, and the TypeScript client all move 1.879.0 → 1.879.1 uniformly.
  • Changelog entries cite the wrong commits — dismissed: each of the three listed fixes (cbf44b3, 6c2c5cf, 7fa093f) matches the actual commit SHA and subject in the range, and the compare link v1.879.0...v1.879.1 is correct.
  • Wrong bump size — dismissed: only fix: commits landed since v1.879.0, so a patch bump is correct.
  • Non-version changes in the other 21 files — dismissed: backend/Cargo.toml, windmill-parser-wasm/Cargo.{toml,lock}, all package*.json files, and the other config files contain only 1.879.0/1.879.1 substitutions (verified by filtering the diff). The only non-version change anywhere is the pin-project family in backend/Cargo.lock, flagged above.

AGENTS.md compliance

Nothing in AGENTS.md governs generated release metadata; no code, docs, or public surface changes are present. The Cargo.lock observation is a release-hygiene concern, not an AGENTS.md rule violation.

Test coverage

CI / workflows / config-only — no automated tests expected.

No manual verification is needed: there is no in-app surface to exercise, and the version strings and changelog are consistent. The one thing worth a human glance before tagging is the backend/Cargo.lock dependency bump called out above (confirming pin-project 1.2.0 / syn 3.0.10 is acceptable to ship in a patch release).

@windmill-internal-app

Copy link
Copy Markdown
Contributor

🤖 Updated ee-repo-ref.txt to be3764042a775e7da1a24b7f57bae1d294cfd5e8 after windmill-ee-private PR #998 was merged.

@rubenfiszel rubenfiszel changed the title chore(main): release 1.879.1 chore(main): release 1.880.0 Nov 19, 2026
@rubenfiszel
rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 9f7a4f5 to da7c523 Compare November 19, 2026 17:34
@github-actions

Copy link
Copy Markdown
Contributor

Pi Review

cc @rubenfiszel

Mergeable, but should ideally address nits: unannounced transitive dependency upgrades in backend/Cargo.lock; fix: commit #12546 absent from CHANGELOG.md.

Findings

P2 — backend/Cargo.lock:9832-9852 — release silently bumps three transitive crates that no commit was tested against

The release workflow's "Apply automatic changes" commit (676de757ab) runs cargo generate-lockfile (.github/workflows/change-versions.yml, update lockfile step), which re-resolves the entire dependency graph rather than only the windmill-* version fields. This release therefore carries, beyond the 1.879.0 → 1.879.1 substitutions:

  • pin-project 1.1.13 → 1.2.0 (:9832)
  • pin-project-internal 1.1.13 → 1.2.0 (:9841), whose proc-macro dep moves syn 2.0.119 → 3.0.10 (:9848; syn 3 was already in the graph, so no new crate, just a re-resolution)
  • pin-project-lite 0.2.17 → 0.2.18 (:9852)

These are real version changes, not string substitutions — the parser-wasm lockfile diff is pure windmill-* bumps by comparison. The practical effect: the v1.879.1 binaries are built against pin-project 1.2.0 / pin-project-lite 0.2.18, which no commit in the 1.879.1 range was compiled or tested against, and none of it is announced in the changelog. Low risk in practice (semver-compatible), but worth a human glance at the regenerated lockfile before tagging so a patch release doesn't quietly ship dependency changes.

P2 — CHANGELOG.md:4-10 — omits the fix: commit "keep the python client generator within memory" (#12546)

The release range v1.879.0 (87c9d0d) … 4472b5b94 contains four commits, three of which are fix: and are listed correctly. The fourth, 4472b5b94 (#12546), is a fix in substance (a memory-perf change to the Python client generator) but its subject lacks a conventional-commit prefix, so Release Please (release-type: "simple") drops it from the changelog. Minor completeness gap; the release itself is correct, just under-documented.

Considered and dismissed

  • Version inconsistency across the 23 touched files — dismissed: .release-please-manifest.json, version.txt, backend/Cargo.toml (package + workspace), every windmill-* entry in both Cargo.locks, all package.json/package-lock.json pairs, openapi.yaml, openflow.openapi.yaml, benchmarks/lib.ts, cli/src/core/constants.ts, lsp/Pipfile, the PowerShell manifest, pyproject.toml, and the TypeScript client all move 1.879.0 → 1.879.1 uniformly (verified per-file).
  • Wrong bump size — dismissed: only fix: commits (plus one un-prefixed fix) landed since v1.879.0, so a patch bump is correct.
  • Malformed compare link — dismissed: v1.879.0...v1.879.1 follows the exact pattern of the adjacent 1.879.0 section (v1.878.0...v1.879.0).
  • backend/ee-repo-ref.txt change — dismissed: it's a routine EE-repo-ref bump in the separate chore: update ee-repo-ref commit, confirmed by the windmill-internal-app bot comment tying it to a merged EE PR; not a release artifact.
  • syn 2 → 3 as a "new" dependency — dismissed as a standalone finding: syn 3.0.10 was already resolved elsewhere in the graph (many existing references), so this is a re-resolution of one crate's pointer, folded into the pin-project finding above.

AGENTS.md compliance

Nothing in AGENTS.md governs generated release metadata; no code, docs, or public-surface changes are present. The Cargo.lock observation is a release-hygiene concern rather than an AGENTS.md rule violation.

Test coverage

CI / workflows / config-only — no automated tests expected.

No manual verification is needed: there is no in-app surface to exercise, and the version strings and changelog are internally consistent. The one thing worth a human glance before tagging is the backend/Cargo.lock dependency bump called out above (confirming pin-project 1.2.0 / pin-project-lite 0.2.18 is acceptable to ship in a patch release).

@github-actions

Copy link
Copy Markdown
Contributor

Codex Review

Good to merge

No issues found in the exact three-file diff. Release metadata consistently specifies 1.880.0, and all four changelog entries match their cited commits.

Test coverage

No automated tests are expected for this metadata-only change. Read-only checks passed for manifest JSON parsing, version consistency, changelog references, and git diff --check.

There is no in-app surface to exercise; no manual verification is needed before merge.

@github-actions

Copy link
Copy Markdown
Contributor

Pi Review

Mergeable, but should ideally address nits: fix: commit #12546 absent from CHANGELOG.md.

Findings

P2 — CHANGELOG.md:11-15 — the fix: commit "keep the python client generator within memory" (#12546) is missing from the 1.880.0 section

The release range v1.879.0 (87c9d0d) … 5583c68 (this PR's base) contains five commits:

  • 5583c68 feat: record and download a worker group's autoscaling decisions (#12542) → listed under Features ✓
  • 4472b5b94 keep the python client generator within memory (#12546) → omitted
  • 6c2c5cf fix: hold the configured AI key to its output token limits (#12543) → listed ✓
  • cbf44b3 fix(api): noindex public app pages on cloud (#12547) → listed ✓
  • 7fa093f fix: keep the AI sessions view mounted across navigation (#12479) → listed ✓

#12546 is a fix in substance — the PR's own title was "fix: keep the python client generator within memory" — but the squashed merge commit subject dropped the fix: prefix, so Release Please (release-type: "simple", per release-please-config.json) classifies it as untyped and omits it. Minor completeness gap; the version bump itself is correct, only the changelog is under-documented. Worth a one-line manual addition if full coverage of the range is desired.

Considered and dismissed

  • Version inconsistency across the three touched files — dismissed: .release-please-manifest.json (".": "1.880.0"), version.txt (1.880.0), and the new CHANGELOG.md heading all agree.
  • Wrong bump size — dismissed: a feat: commit (feat: record and download a worker group's autoscaling decisions #12542) landed since v1.879.0, so a minor bump (1.879.0 → 1.880.0) is correct rather than a patch.
  • Changelog cites the wrong SHAs — dismissed: each entry's SHA (5583c68, cbf44b3, 6c2c5cf, 7fa093f) matches the actual commit subject verified via git log.
  • Malformed compare link — dismissed: v1.879.0...v1.880.0 matches the adjacent 1.879.0 section's own range pattern (v1.878.0...v1.879.0).
  • Changelog entry ordering — dismissed: Features before Bug Fixes with release-please's deterministic per-section ordering; cosmetic, not a defect.
  • The other ~19 version-bearing files (backend/Cargo.toml, package.jsons, openapi.yaml, etc.) are not bumped in this diff — dismissed: .github/workflows/change-versions.yml fires on any PR touching version.txt and commits those substitutions (plus cargo generate-lockfile) as a follow-up "Apply automatic changes" commit. Not part of the release-please commit itself.
  • Transitive dependency re-resolution in backend/Cargo.lock (the pin-project concern raised in prior reviews) — not present in the current three-file diff; it would only surface in the workflow's follow-up commit, which is outside this diff.

AGENTS.md compliance

Nothing applies: the PR changes only generated release metadata (CHANGELOG.md, .release-please-manifest.json, version.txt), no code, docs, or public surface. No AGENTS.md rule governs release artifacts.

Test coverage

CI / workflows / docs / config-only — no automated tests expected.

No manual verification is needed before merge: there is no in-app surface to exercise, and the version strings and changelog are internally consistent. The only thing worth a human glance is the missing #12546 changelog entry noted above.

@github-actions

Copy link
Copy Markdown
Contributor

Pi Review

cc @rubenfiszel

Mergeable, but should ideally address nits: fix: commit #12546 absent from CHANGELOG.md; unannounced transitive dependency upgrades in backend/Cargo.lock.

Findings

P2 — CHANGELOG.md:11-15 — the fix: commit "keep the python client generator within memory" (#12546) is missing from the 1.880.0 section

The range v1.879.0 (87c9d0d1fe) … 5583c68 (this PR's base) contains five commits:

  • 5583c68 feat: record and download a worker group's autoscaling decisions (#12542) → listed under Features ✓
  • 4472b5b94 keep the python client generator within memory (#12546) → omitted
  • 6c2c5cf fix: hold the configured AI key to its output token limits (#12543) → listed ✓
  • cbf44b3 fix(api): noindex public app pages on cloud (#12547) → listed ✓
  • 7fa093f fix: keep the AI sessions view mounted across navigation (#12479) → listed ✓

4472b5b94 is a fix in substance — its PR title was fix: keep the python client generator within memory — but the squashed merge commit subject dropped the fix: prefix, so Release Please (release-type: "simple" per release-please-config.json) classifies it as untyped and omits it. Minor completeness gap; the version bump itself is correct, only the changelog is under-documented. Worth a one-line manual addition if full coverage of the range is desired.

P2 — backend/Cargo.lock:9832-9853 — release silently bumps three transitive crates that no commit was tested against

The release workflow's "Apply automatic changes" commit (9c144a2bfc) runs cargo generate-lockfile (.github/workflows/change-versions.yml:29), which re-resolves the entire dependency graph rather than only the windmill-* version fields. Beyond the 1.879.0 → 1.880.0 substitutions, this release carries:

  • pin-project 1.1.13 → 1.2.0 (:9833)
  • pin-project-internal 1.1.13 → 1.2.0 (:9842), whose proc-macro dependency moves syn 2.0.119 → 3.0.10 (:9848)
  • pin-project-lite 0.2.17 → 0.2.18 (:9853)

These are real version changes, not string substitutions — verified by filtering the diff for any +/- line that is not a 1.879.0/1.880.0 swap, which yields only the pin-project family. The parser-wasm lockfile is pure windmill-* bumps by comparison. The practical effect: the tagged v1.880.0 binaries will be built against pin-project 1.2.0 / pin-project-lite 0.2.18, which no commit in the 1.880.0 range was compiled or tested against, and none of it is announced in the changelog. Low risk in practice (semver-compatible bumps), but worth a human glance at the regenerated lockfile before tagging so a minor release doesn't quietly ship dependency changes.

Considered and dismissed

  • Version inconsistency across the 22 touched files — dismissed: .release-please-manifest.json, version.txt, backend/Cargo.toml (package + workspace), every windmill-* entry in both Cargo.locks, all package.json/package-lock.json pairs, openapi.yaml, openflow.openapi.yaml, benchmarks/lib.ts, cli/src/core/constants.ts, lsp/Pipfile, the PowerShell manifest, pyproject.toml, and the TypeScript client all move 1.879.0 → 1.880.0 uniformly.
  • Wrong bump size — dismissed: a feat: commit (feat: record and download a worker group's autoscaling decisions #12542) landed since v1.879.0, so a minor bump (1.879.0 → 1.880.0) is correct rather than a patch.
  • Changelog cites the wrong SHAs — dismissed: each listed entry's SHA matches the actual commit subject verified via git log.
  • Malformed compare link — dismissed: v1.879.0...v1.880.0 follows the exact pattern of the adjacent 1.879.0 section (v1.878.0...v1.879.0).
  • Changelog entry ordering — dismissed: Features before Bug Fixes is release-please's deterministic per-section ordering; cosmetic, not a defect.
  • syn 2 → 3 as a standalone "new dependency" — dismissed: syn 3.0.10 was already resolved elsewhere in the graph; this is a re-resolution of one crate's pointer, folded into the pin-project finding above.

AGENTS.md compliance

Nothing in AGENTS.md governs generated release metadata; no code, docs, or public-surface changes are present. The Cargo.lock observation is a release-hygiene concern rather than an AGENTS.md rule violation.

Test coverage

CI / workflows / config-only — no automated tests expected.

No manual verification is needed before merge: there is no in-app surface to exercise, and the version strings and changelog are internally consistent. The two things worth a human glance before tagging are the missing #12546 changelog entry and the backend/Cargo.lock dependency bump called out above (confirming pin-project 1.2.0 / pin-project-lite 0.2.18 is acceptable to ship in a minor release).

@github-actions

Copy link
Copy Markdown
Contributor

Codex Review

Good to merge

No issues found. Release metadata consistently specifies 1.880.0. The three pin-project family upgrades have consistent lockfile references.

Test coverage

No new tests are expected for the release metadata. Read-only checks passed for version substitutions, JSON/TOML parsing, changelog references, changed dependency references, and git diff --check.

Compilation and runtime tests were not run; backend CI should validate the dependency upgrades. There is no new in-app surface to exercise.

@rubenfiszel
rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 9c144a2 to 0822541 Compare November 19, 2026 18:19
@github-actions

Copy link
Copy Markdown
Contributor

Pi Review

cc @rubenfiszel

Mergeable, but should ideally address nits: fix: commit #12546 absent from CHANGELOG.md.

Findings

P2 — CHANGELOG.md:11-16 — the fix: commit "keep the python client generator within memory" (#12546) is missing from the 1.880.0 section

The release range v1.879.0 (87c9d0d1fe) … 50daf70 (this PR's base) contains six commits:

  • 50daf70 fix: name a step inside a subflow sub:inner in flow tests (#12549) → listed ✓
  • 5583c68 feat: record and download a worker group's autoscaling decisions (#12542) → listed ✓
  • 4472b5b keep the python client generator within memory (#12546) → omitted
  • 6c2c5cf fix: hold the configured AI key to its output token limits (#12543) → listed ✓
  • cbf44b3 fix(api): noindex public app pages on cloud (#12547) → listed ✓
  • 7fa093f fix: keep the AI sessions view mounted across navigation (#12479) → listed ✓

4472b5b is a fix in substance — its PR's first commit was titled fix: keep the python client generator within memory (verified via git show), and the body includes a follow-up chore: state the generator's real memory peak. But the squashed merge subject dropped the fix: prefix, and release-please-config.json declares release-type: "simple", which only classifies conventional-commit-prefixed subjects. The commit is therefore omitted from the changelog. Minor completeness gap: the version bump itself is correct, only the changelog is under-documented. Worth a one-line manual addition under Bug Fixes if full coverage of the range is desired.

Considered and dismissed

  • Version inconsistency across files — dismissed: .release-please-manifest.json (".": "1.880.0"), version.txt (1.880.0), and the new CHANGELOG.md heading all agree, and the diff touches only these three files.
  • Wrong bump size — dismissed: a feat: commit (feat: record and download a worker group's autoscaling decisions #12542) landed since v1.879.0, so a minor bump (1.879.0 → 1.880.0) is correct rather than a patch.
  • Changelog cites the wrong SHAs / subjects — dismissed: each listed entry's short SHA matches the actual commit subject verified via git log (5583c68, cbf44b3, 6c2c5cf, 7fa093f, 50daf70), including 50daf70 which is this PR's own base SHA.
  • Malformed compare link — dismissed: v1.879.0...v1.880.0 follows the exact pattern of the adjacent 1.879.0 section (v1.878.0...v1.879.0).
  • Changelog entry ordering — dismissed: Features before Bug Fixes is Release Please's deterministic per-section ordering; cosmetic, not a defect.
  • Transitive dependency re-resolution in backend/Cargo.lock (the pin-project concern raised in earlier reviews) — not present in the current three-file diff; it would only surface in the change-versions.yml "Apply automatic changes" follow-up commit, which is outside this diff (git diff base...head shows only .release-please-manifest.json, CHANGELOG.md, version.txt).

AGENTS.md compliance

Nothing applies: the PR changes only generated release metadata (CHANGELOG.md, .release-please-manifest.json, version.txt) — no code, docs, or public surface. No AGENTS.md rule governs release artifacts.

Test coverage

CI / workflows / docs / config-only — no automated tests expected.

No manual verification is needed before merge: there is no in-app surface to exercise, and the version strings and changelog are internally consistent. The only thing worth a human glance is the missing #12546 changelog entry noted above.

@github-actions

Copy link
Copy Markdown
Contributor

Pi Review

cc @rubenfiszel

Mergeable, but should ideally address nits: fix: commit #12546 absent from CHANGELOG.md; unannounced transitive dependency upgrades in backend/Cargo.lock.

Findings

P2 — CHANGELOG.md:11-16 — the fix: commit "keep the python client generator within memory" (#12546) is missing from the 1.880.0 section

The release range v1.879.0 (87c9d0d1fe) … 50daf70337 (this PR's base) contains six commits:

  • 50daf70337 fix: name a step inside a subflow sub:inner in flow tests (#12549) → listed ✓
  • 5583c680d4 feat: record and download a worker group's autoscaling decisions (#12542) → listed under Features ✓
  • 4472b5b94b keep the python client generator within memory (#12546) → omitted
  • 6c2c5cf46c fix: hold the configured AI key to its output token limits (#12543) → listed ✓
  • cbf44b36f3 fix(api): noindex public app pages on cloud (#12547) → listed ✓
  • 7fa093f7d4 fix: keep the AI sessions view mounted across navigation (#12479) → listed ✓

4472b5b94b is a fix in substance — its body's first commit was titled fix: keep the python client generator within memory — but the squashed merge subject dropped the fix: prefix. release-please-config.json declares release-type: "simple", which only classifies conventional-commit-prefixed subjects, so the commit is dropped from the changelog. Minor completeness gap; the version bump itself is correct, only the changelog is under-documented. Worth a one-line manual addition under Bug Fixes if full coverage of the range is desired.

P2 — backend/Cargo.lock:9832-9853 — release silently bumps three transitive crates that no commit was tested against

The release's "Apply automatic changes" commit runs cargo generate-lockfile (.github/workflows/change-versions.yml:29), which re-resolves the entire dependency graph rather than only the windmill-* version fields. Beyond the 1.879.0 → 1.880.0 substitutions, this release carries real dependency changes:

  • pin-project 1.1.13 → 1.2.0 (:9833)
  • pin-project-internal 1.1.13 → 1.2.0 (:9842), whose proc-macro dependency moves syn 2.0.119 → 3.0.10 (:9848; syn 3.0.10 was already elsewhere in the graph, so this is a pointer re-resolution, not a new crate)
  • pin-project-lite 0.2.17 → 0.2.18 (:9853)

These are genuine version changes, not string substitutions — filtering the diff for any +/- line that is not a 1.879.0/1.880.0 swap yields only the pin-project family (the parser-wasm lockfile is pure windmill-* bumps by comparison). The practical effect: the tagged v1.880.0 binaries will be built against pin-project 1.2.0 / pin-project-lite 0.2.18, which no commit in the 1.880.0 range was compiled or tested against, and none of it is announced in the changelog. Low risk (semver-compatible), but worth a human glance at the regenerated lockfile before tagging so a minor release doesn't quietly ship dependency changes.

Considered and dismissed

  • Version inconsistency across the 22 touched files — dismissed: .release-please-manifest.json, version.txt, backend/Cargo.toml (package + workspace), windmill-parser-wasm/Cargo.toml, every windmill-* entry in both Cargo.locks, all package.json/package-lock.json pairs, openapi.yaml, openflow.openapi.yaml, benchmarks/lib.ts, cli/src/core/constants.ts, lsp/Pipfile, the PowerShell manifest, pyproject.toml, jsr.json, and the TypeScript client all move 1.879.0 → 1.880.0 uniformly.
  • Wrong bump size — dismissed: a feat: commit (feat: record and download a worker group's autoscaling decisions #12542) landed since v1.879.0, so a minor bump (1.880.0) is correct rather than a patch.
  • Changelog cites the wrong SHAs / subjects — dismissed: each listed entry's short SHA matches the actual commit subject verified via git log (5583c68, cbf44b3, 6c2c5cf, 7fa093f, 50daf70).
  • Malformed compare link — dismissed: v1.879.0...v1.880.0 follows the exact pattern of the adjacent 1.879.0 section (v1.878.0...v1.879.0).
  • Changelog entry ordering — dismissed: Features before Bug Fixes is Release Please's deterministic per-section ordering; cosmetic, not a defect.
  • syn 2.0.119 removal / syn 3.0.10 as a "new" dependency — dismissed as a standalone finding: syn 2.0.119 is still referenced 82 times elsewhere and syn 3.0.10 was already present in the graph, so this is one crate's dependency pointer moving, folded into the pin-project finding above.
  • Non-version changes smuggled into the other 21 files — dismissed: verified the backend/Cargo.toml, frontend/package.json, and typescript-client/package.json diffs contain only the version substitution; the only non-version change in the entire diff is the pin-project family called out above.

AGENTS.md compliance

Nothing applies: the PR changes only generated release metadata (CHANGELOG.md, .release-please-manifest.json, version.txt, and the derived version strings in build/config files) plus the lockfile re-resolution. No AGENTS.md rule governs release artifacts; the Cargo.lock observation is a release-hygiene concern, not an AGENTS.md rule violation.

Test coverage

CI / workflows / docs / config-only — no automated tests expected. The 22-file diff is release versioning and lockfile re-resolution with no code, API, frontend, or public-surface changes.

No manual verification is needed before merge: there is no in-app surface to exercise, and the version strings and changelog are internally consistent. The two things worth a human glance before tagging are the missing #12546 changelog entry and the backend/Cargo.lock pin-project bump (confirming pin-project 1.2.0 / pin-project-lite 0.2.18 is acceptable to ship in a minor release).

@github-actions

Copy link
Copy Markdown
Contributor

Codex Review

Good to merge

No issues found. The 22-file diff consistently updates release versions to 1.880.0. The three pin-project family upgrades have consistent lockfile references.

Test coverage

No new automated tests are expected for release metadata. Read-only checks passed for version substitutions, JSON/TOML parsing, changelog references, changed dependency references, and git diff --check.

Compilation and runtime tests were not run; backend CI should validate the dependency upgrades. There is no new in-app surface to exercise, so no manual verification is needed.

@rubenfiszel
rubenfiszel merged commit b40552c into main Nov 19, 2026
20 of 21 checks passed
@rubenfiszel
rubenfiszel deleted the release-please--branches--main--components--windmill branch November 19, 2026 18:24
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 19, 2026
@rubenfiszel

Copy link
Copy Markdown
Contributor Author

🤖 Created releases:

🌻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant