Implement proper scene cloning#311
Merged
Merged
Conversation
`clone` required context binding but that beats the purpose of static methods
Previous version of scening did a copy by reference thus destroying the uniqueness of scenes causing a change in one scene to affect the other
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
TypeRegistryclone()implementationsSolution
1. Incorrect
this.copyusage in static contextUsing
this.copy()inside static methods is unsafe under inheritance. It may resolve to the wrong constructor or break when methods are detached and no context binding forthis.Fix:
Replaced all:
with:
Why:
Ensures deterministic dispatch and avoids reliance on dynamic
thisbinding in static context.2. Centralized cloning via
TypeRegistryProblem:
Scene instantiation previously reused component references (no cloning), leading to:
Changes:
TypeRegistryAdditional behavior:
Parentif missing → guarantees hierarchy integrity.Why this approach:
Showcase
New demos:
multiple_instances(2D & 3D)Migration guide
Now requires:
Custom components
If you want your component to be scene-compatible:
TypeRegistryNotes
clonewill be skipped with a warningChecklist